After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672830 - Export GSSDPResourceGroup in GUPnPRootDevice (to set ie., max-age)
Export GSSDPResourceGroup in GUPnPRootDevice (to set ie., max-age)
Product: GUPnP
Classification: Other
Component: gupnp
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Reported: 2012-03-26 08:00 UTC by Branislav Katreniak
Modified: 2012-11-30 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch exporting GSSDPResourceGroup in GUPnPRootDevice (1.52 KB, patch)
2012-03-26 08:00 UTC, Branislav Katreniak
none Details | Review
Expose GSSDPResourceGroup of root device. (2.32 KB, patch)
2012-11-30 14:05 UTC, Jens Georg
committed Details | Review

Description Branislav Katreniak 2012-03-26 08:00:16 UTC
Created attachment 210603 [details] [review]
Patch exporting GSSDPResourceGroup in GUPnPRootDevice

We need to adjust SSDP max-age property of upnp root device. 

GSSDPResourceGroup hac public modifiable property max-age. We would like to modify this property for upnp root device.

GUPnPRootDevice has property GSSDPResourceGroup, but this property is kept private. We propose to make this property public.

Attached patch adds method:
GSSDPResourceGroup *gupnp_root_device_get_ssdp_resource_group (GUPnPRootDevice *root_device)

Do you know a better way how to modify max-age of gupnp root device? 
Would you review and accept the proposed patch upstream?
Comment 1 Jens Georg 2012-03-29 10:33:35 UTC
Thank you for your patch, but to me this feels wrong, like exposing internals that shouldn't be exposed.

I think I said before that I would like something like "gupnp_context_new_full (GUPNP_UDA_1_1, ...)", propagating that UDA version across the stack internally so that the appropriate classes know what to do.
Comment 2 Branislav Katreniak 2012-03-29 10:50:35 UTC
Thank you for the response.

All we wanted to do is to set the max-age for SSDP. And we are interested to not carry patches above upstream if possible.

We are willing further work on the patch if it likely to get merged.
But I don't understand the UDA term. My feeling is that you implement this faster yourself then the time required to explain us what you want. 

I believe that we are not in the position to provide an acceptable patch. Feel free to resolve and close this issue. We will simply carry the patch until an official solution is provided.
Comment 3 Branislav Katreniak 2012-03-29 10:52:11 UTC
Just one note about the API for comparison .... gupnp happily exposes libsoup internals.
Comment 4 Jens Georg 2012-03-29 11:13:18 UTC
Actually I might have mixed up things a bit with bug 668922.
Comment 5 Jens Georg 2012-11-30 14:05:10 UTC
Created attachment 230278 [details] [review]
Expose GSSDPResourceGroup of root device.

Based on patch by Branislav Katreniak

Comment 6 Jens Georg 2012-11-30 14:44:10 UTC
Attachment 230278 [details] pushed as 31d610e - Expose GSSDPResourceGroup of root device.