GNOME Bugzilla – Bug 672830
Export GSSDPResourceGroup in GUPnPRootDevice (to set ie., max-age)
Last modified: 2012-11-30 14:44:13 UTC
Created attachment 210603 [details] [review]
Patch exporting GSSDPResourceGroup in GUPnPRootDevice
We need to adjust SSDP max-age property of upnp root device.
GSSDPResourceGroup hac public modifiable property max-age. We would like to modify this property for upnp root device.
GUPnPRootDevice has property GSSDPResourceGroup, but this property is kept private. We propose to make this property public.
Attached patch adds method:
GSSDPResourceGroup *gupnp_root_device_get_ssdp_resource_group (GUPnPRootDevice *root_device)
Do you know a better way how to modify max-age of gupnp root device?
Would you review and accept the proposed patch upstream?
Thank you for your patch, but to me this feels wrong, like exposing internals that shouldn't be exposed.
I think I said before that I would like something like "gupnp_context_new_full (GUPNP_UDA_1_1, ...)", propagating that UDA version across the stack internally so that the appropriate classes know what to do.
Thank you for the response.
All we wanted to do is to set the max-age for SSDP. And we are interested to not carry patches above upstream if possible.
We are willing further work on the patch if it likely to get merged.
But I don't understand the UDA term. My feeling is that you implement this faster yourself then the time required to explain us what you want.
I believe that we are not in the position to provide an acceptable patch. Feel free to resolve and close this issue. We will simply carry the patch until an official solution is provided.
Just one note about the API for comparison .... gupnp happily exposes libsoup internals.
Actually I might have mixed up things a bit with bug 668922.
Created attachment 230278 [details] [review]
Expose GSSDPResourceGroup of root device.
Based on patch by Branislav Katreniak
Attachment 230278 [details] pushed as 31d610e - Expose GSSDPResourceGroup of root device.