Bug 672828 – Crash when trying to accept a subscription request

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 672828 - Crash when trying to accept a subscription request


Summary:	Crash when trying to accept a subscription request


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	General
Version:	2.33.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:	empathy-maint

URL:
Whiteboard:

Duplicates:	674346 (view as bug list)
Depends on:
Blocks:

Reported:	2012-03-26 07:21 UTC by Guillaume Desmottes
Modified:	2012-04-19 15:10 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
contact_widget_contact_update: check if widget_avatar is a chooser (1.25 KB, patch) 2012-03-26 07:29 UTC, Guillaume Desmottes	committed	Details \| Review

Description Guillaume Desmottes 2012-03-26 07:21:15 UTC

GLib-GObject-WARNING **: invalid cast from `EmpathyAvatarImage' to `EmpathyAvatarChooser'

Program received signal SIGTRAP, Trace/breakpoint trap.
0x00007ffff56be06c in g_logv (log_domain=0x7ffff59f1070 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, 
    format=0x7ffff59f27e0 "invalid cast from `%s' to `%s'", args1=0x7fffffffcc68) at gmessages.c:758
758			G_BREAKPOINT ();
(gdb) bt

+ Trace 229950

#0 g_logv
at gmessages.c line 758
#1 g_log
at gmessages.c line 792
#2 g_type_check_instance_cast
at gtype.c line 4007
#3 contact_widget_contact_update
at empathy-contact-widget.c line 1410
#4 contact_widget_set_contact
at empathy-contact-widget.c line 1485
#5 empathy_contact_widget_new
at empathy-contact-widget.c line 1800
#6 empathy_subscription_dialog_show
at empathy-contact-dialogs.c line 144
#7 event_pending_subscribe_func
at empathy-event-manager.c line 1177
#8 empathy_event_activate
at empathy-event-manager.c line 1588
#9 roster_window_row_activated_cb
at empathy-roster-window.c line 599
#10 _gtk_marshal_VOID__BOXED_OBJECT
at gtkmarshalers.c line 3086
#11 g_closure_invoke
at gclosure.c line 777
#12 signal_emit_unlocked_R
at gsignal.c line 3547
#13 g_signal_emit_valist
at gsignal.c line 3295
#14 g_signal_emit
at gsignal.c line 3352
#15 gtk_tree_view_row_activated
at gtktreeview.c line 12567
#16 gtk_tree_view_button_press
at gtktreeview.c line 3182
#17 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 85
#18 g_type_class_meta_marshal
at gclosure.c line 970
#19 g_closure_invoke
at gclosure.c line 777
#20 signal_emit_unlocked_R
at gsignal.c line 3585
#21 g_signal_emit_valist
at gsignal.c line 3305
#22 g_signal_emit
at gsignal.c line 3352
#23 gtk_widget_event_internal
at gtkwidget.c line 6380
#24 gtk_widget_event
at gtkwidget.c line 6037
#25 propagate_event_up
at gtkmain.c line 2390
#26 propagate_event
at gtkmain.c line 2490
#27 gtk_propagate_event
at gtkmain.c line 2525
#28 gtk_main_do_event
at gtkmain.c line 1660
#29 _gdk_event_emit
at gdkevents.c line 69
#30 gdk_event_source_dispatch
at gdkeventsource.c line 358
#31 g_main_dispatch
at gmain.c line 2510
#32 g_main_context_dispatch
at gmain.c line 3047
#33 g_main_context_iterate
at gmain.c line 3118
#34 g_main_context_iteration
at gmain.c line 3179
#35 g_application_run
at gapplication.c line 1496
#36 main
at empathy.c line 867

Comment 1 Guillaume Desmottes 2012-03-26 07:29:14 UTC

Created attachment 210602 [details] [review]
contact_widget_contact_update: check if widget_avatar is a chooser

information->widget_avatar can actually be a EmpathyAvatarImage when
displaying a read only widget.

Comment 2 Xavier Claessens 2012-03-26 07:34:08 UTC

Usually that code does if (information->flags & EMPATHY_CONTACT_WIDGET_EDIT_AVATAR) instead. But that's fine as you did :) That code is all ugly anyway :)

Comment 3 Guillaume Desmottes 2012-03-26 07:35:20 UTC

Attachment 210602 [details] pushed as 1454a06 - contact_widget_contact_update: check if widget_avatar is a chooser

Comment 4 Guillaume Desmottes 2012-04-19 15:10:27 UTC

*** Bug 674346 has been marked as a duplicate of this bug. ***