After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672807 - More minor dead code removal
More minor dead code removal
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-25 15:09 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-05-18 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-bin: Remove unnecessary foreach implementation (1016 bytes, patch)
2012-03-25 15:09 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
gnome-shell-plugin: Remove useless dispose/finalize handlers (1.87 KB, patch)
2012-03-25 15:09 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
global: Remove XSettings font handling code (3.60 KB, patch)
2012-03-26 15:13 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st: Remove our own font DPI resolution implementation (8.18 KB, patch)
2012-03-26 15:13 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-03-25 15:09:44 UTC 
See patches.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-25 15:09:46 UTC 
Created attachment 210579 [details] [review]
st-bin: Remove unnecessary foreach implementation
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-25 15:09:49 UTC 
Created attachment 210580 [details] [review]
gnome-shell-plugin: Remove useless dispose/finalize handlers
Comment 3 Giovanni Campagna 2012-03-25 15:13:08 UTC 
Review of attachment 210579 [details] [review]:

Looks good.
Comment 4 Giovanni Campagna 2012-03-25 15:13:37 UTC 
Review of attachment 210580 [details] [review]:

LGTM
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-03-26 15:13:14 UTC 
Created attachment 210633 [details] [review]
global: Remove XSettings font handling code

Clutter now has its own XSettings implementation, ClutterSettings, which
handles this automatically now.



More dead code.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-03-26 15:13:21 UTC 
Created attachment 210634 [details] [review]
st: Remove our own font DPI resolution implementation

Clutter has had clutter_backend_get_resolution for a little while.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-05-02 14:21:08 UTC 
Attachment 210579 [details] pushed as a9a3687 - st-bin: Remove unnecessary foreach implementation
Attachment 210580 [details] pushed as 507df9e - gnome-shell-plugin: Remove useless dispose/finalize handlers
Comment 8 drago01 2012-05-18 17:37:43 UTC 
Review of attachment 210633 [details] [review]:

LG.
Comment 9 drago01 2012-05-18 17:40:17 UTC 
Review of attachment 210634 [details] [review]:

Looks good.
Comment 10 Jasper St. Pierre (not reading bugmail) 2012-05-18 17:57:36 UTC 
Attachment 210633 [details] pushed as dc3d3ac - global: Remove XSettings font handling code
Attachment 210634 [details] pushed as de8a66d - st: Remove our own font DPI resolution implementation