After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672805 - Port to newer libgweather
Port to newer libgweather
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Calendar
3.6.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2012-03-25 14:27 UTC by Giovanni Campagna
Modified: 2013-09-14 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
weather: update for newer GWeather (31.46 KB, patch)
2012-03-25 14:28 UTC, Giovanni Campagna
none Details | Review
weather: update for newer GWeather (32.67 KB, patch)
2012-06-25 22:07 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-03-25 14:27:39 UTC
libgweather 3.5.0 changed WeatherInfo API for the GSettings and introspectability ports, and evolution-data-server needs to be updated accordingly.
Comment 1 Giovanni Campagna 2012-03-25 14:28:14 UTC
Created attachment 210573 [details] [review]
weather: update for newer GWeather

GWeather 3.6 changed API to be properly namespaced and GObject based.
Also, WeatherLocation was removed and replaced with GWeatherLocation
in all public API (with additionally the possibility to retrieve one
particular GWeatherLocation by station code)
At the same time, remove a old and now useless abstration by folding
EWeatherSourceCCF into EWeatherSource.
Comment 2 Matthew Barnes 2012-03-25 14:48:49 UTC
We're going to need to retain backward compatibility until libgweather-3.6.0 is released, since we don't require unstable libraries.
Comment 3 Giovanni Campagna 2012-03-25 15:02:59 UTC
libgweather 3.6 will be released as the same time as evolution-data-server 3.6. In the mean time, you cannot use libgweather 3.4 as they're not parallel installable.
Comment 4 Matthew Barnes 2012-03-25 15:06:47 UTC
That's fine.  Both e-d-s and evo have configure options to exclude libgweather, and we'll cap the maximum supported version at < 3.5.0 until we're ready to support both API versions.
Comment 6 Giovanni Campagna 2012-06-25 22:07:29 UTC
Created attachment 217248 [details] [review]
weather: update for newer GWeather

GWeather 3.6 changed API to be properly namespaced and GObject based.
Also, WeatherLocation was removed and replaced with GWeatherLocation
in all public API (with additionally the possibility to retrieve one
particular GWeatherLocation by station code)
At the same time, remove a old and now useless abstration by folding
EWeatherSourceCCF into EWeatherSource.

Rebased on current master.
Comment 7 Milan Crha 2012-06-27 12:49:42 UTC
Comment on attachment 217248 [details] [review]
weather: update for newer GWeather

Thanks for a patch. it builds fine, please commit to master.
Comment 8 Milan Crha 2012-06-27 12:50:40 UTC
Just for a record, evolution also contains gweather parts, the configuration module/plugin for weather calendar requires it.
Comment 9 Giovanni Campagna 2012-06-27 14:07:11 UTC
Attachment 217248 [details] pushed as c51c56f - weather: update for newer GWeather