After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672792 - Also try gdk-pixbuf-query-loaders-64 when searching for query-loaders
Also try gdk-pixbuf-query-loaders-64 when searching for query-loaders
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-25 10:51 UTC by Maarten Bosmans
Modified: 2013-11-12 03:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Also try gdk-pixbuf-query-loaders-64 when searching for query-loaders (555 bytes, patch)
2012-03-25 10:51 UTC, Maarten Bosmans
none Details | Review

Description Maarten Bosmans 2012-03-25 10:51:15 UTC
Created attachment 210556 [details] [review]
Also try gdk-pixbuf-query-loaders-64 when searching for query-loaders

On some distro's the -64 suffix is added on x86_64.
Comment 1 Christian Persch 2012-03-25 12:14:13 UTC
Please commit to master. (Build fix only, so not affected by freeze.)
Comment 2 Christian Persch 2012-03-26 12:01:14 UTC
Committed. In future, please attach patchs in git format-patch format which makes applying them much easier.
Comment 3 Cameron Gregory 2013-11-11 04:07:17 UTC
This patch sometimes finds the wrong query-loader.

If you are on say centos (which has the -64 in /usr/bin), and are building your own version of librsvg, with also newer version of gdk-pixbuf (which doesn't build the -64), then it always finds the -64 which is the wrong one.

So then wrong query loader configures the wrong loaders.

Cameron
Comment 4 Christian Persch 2013-11-11 09:52:46 UTC
Would reordering the list so that the unsuffixed one is looked for first fix this?
Comment 5 Cameron Gregory 2013-11-12 03:09:34 UTC
For me it would, but I can also imagine that the reverse is true for someone else.

Option a:

Look along the path...

PATH=/home/rsvg/bin:/usr/bin

LOADERS=gdk-pixbuf-query-loaders-64,gdk-pixbuf-query-loaders-32,gdk-pixbuf-query-loaders

look in this order:

/home/rsvg/bin/gdk-pixbuf-query-loaders-64
/home/rsvg/bin/gdk-pixbuf-query-loaders-32
/home/rsvg/bin/gdk-pixbuf-query-loaders
/usr/bin/gdk-pixbuf-query-loaders-64
/usr/bin/gdk-pixbuf-query-loaders-32
/usr/bin/gdk-pixbuf-query-loaders

Option b:
probably much better.

Only look in the directory specified in lib/pgkconfig/gdk-pixbuf-2.0.pc

${exec_prefix}/bin/gdk-pixbuf-query-loaders-64
${exec_prefix}/bin/gdk-pixbuf-query-loaders-32
${exec_prefix}/bin/gdk-pixbuf-query-loaders

Cameron