After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672772 - glib-single-include: glib/gbytes.h missing
glib-single-include: glib/gbytes.h missing
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-03-24 21:32 UTC by Michael Biebl
Modified: 2012-03-29 22:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Michael Biebl 2012-03-24 21:32:39 UTC
> I did a test rebuild of the Debian archive and found 125 packages which
> failed to build with the new glib (2.31.22) [1].
> I'm going to file bug reports against those packages, but I wonder what
> the now recommended practise is, as I found the following headers which
> don't generate that error:

Thanks for doing this work !

>  glib/gbytes.h

This is an oversight. Please file a bug against glib for it (or just
commit the obvious fix).

>  glib/gi18n.h
>  glib/gi18n-lib.h
>  glib/gprintf.h
>  glib/gstdio.h

These are all exceptions, for various reasons that are explained in the
docs somewhere.

[1] http://people.debian.org/~biebl/glib-single-include/
Comment 2 Michael Biebl 2012-03-25 14:15:28 UTC
I've also noticed that glibconfig.h uses #include <glib/gmacros.h>, which will trigger the error.

Is glibconfig.h no longer supposed to be included directly?
Comment 3 Matthias Clasen 2012-03-26 02:32:01 UTC
glibconfig.h gets pulled in via

glib.h -> gtypes.h -> glibconfig.h

so no, it is not supposed to be included individually either
Comment 4 Matthias Clasen 2012-03-29 22:53:12 UTC
I've added the single-include guard to gbytes.h