After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672771 - Missing files in POTFILE.in
Missing files in POTFILE.in
Status: RESOLVED NOTGNOME
Product: Gnumeric
Classification: Applications
Component: Compilation
git master
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2012-03-24 21:03 UTC by Quentin "Sardem FF7" Glidic
Modified: 2012-03-25 21:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch: Add missing files to POTFILES.in (1.21 KB, patch)
2012-03-24 21:03 UTC, Quentin "Sardem FF7" Glidic 		none Details | Review
Patch: Add missing files to POTFILES.skip (927 bytes, patch)
2012-03-25 15:18 UTC, Quentin "Sardem FF7" Glidic 		none Details | Review

Description Quentin "Sardem FF7" Glidic 2012-03-24 21:03:38 UTC 
Created attachment 210531 [details] [review]
Patch: Add missing files to POTFILES.in

When running make check, it fails in po/ and po-functions/, and complains about missing files in POTFILES.in

Attached the patch to fix this issue.
Comment 1 Andreas J. Guelzow 2012-03-25 00:03:57 UTC 
But we really should not need that file in POTFILES.in. THere is nothing translatable in that file!
Comment 2 Morten Welinder 2012-03-25 02:04:47 UTC 
What makes you think embedded-ui should be in POTFILES.in?
Comment 3 Quentin "Sardem FF7" Glidic 2012-03-25 08:18:07 UTC 
According to intltool (0.50.1), it should either be listed in POTFILES.in or POTFILES.skip. I just picked up the first one to add the file. It may not be the correct fix, but it makes the check target happy here.
Comment 4 André Klapper 2012-03-25 15:05:25 UTC 
...so add it to POTFILES.skip?
Comment 5 Quentin "Sardem FF7" Glidic 2012-03-25 15:18:11 UTC 
Created attachment 210582 [details] [review]
Patch: Add missing files to POTFILES.skip

(In reply to comment #4)
> ...so add it to POTFILES.skip?

No problem. Here’s the patch.
Comment 6 Morten Welinder 2012-03-25 18:03:25 UTC 
Thanks.

I really would like to know why intltool wants that.  It feels like
a bug in intltool, but I only have 0.41.1 and it is happy.

Andreas: what do you have?
Comment 7 Andreas J. Guelzow 2012-03-25 18:56:59 UTC 
I am also using intltool 0.41.1.
Comment 8 Morten Welinder 2012-03-25 20:53:19 UTC 
intltool 0.50 is buggy.  It fails to understand C strings.  I have cut
the problem down to this example:

static const char data4[] =
    """"
    """_"
;
Comment 9 Morten Welinder 2012-03-25 21:00:22 UTC 
Reported as https://bugs.launchpad.net/intltool/+bug/964785
Comment 10 Morten Welinder 2012-03-25 21:15:28 UTC 
Worked around in the embedder -- we work harder at not having lines start
with three quotes.