After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672719 - a11y: Set a name for the keyboard status icon
a11y: Set a name for the keyboard status icon
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-23 20:19 UTC by Florian Müllner
Modified: 2012-04-13 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a11y: Set a name for the keyboard status icon (893 bytes, patch)
2012-03-23 20:19 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-03-23 20:19:51 UTC 
See attached patch - apparently the keyboard menu was missed in bug 667376. The code change is trivial, and as far as I understand it does not break string freeze, so maybe it's still worth getting in ...
Comment 1 Florian Müllner 2012-03-23 20:19:53 UTC 
Created attachment 210484 [details] [review]
a11y: Set a name for the keyboard status icon
Comment 2 Matthias Clasen 2012-03-24 02:56:35 UTC 
I've tested this - it works as expected.
Comment 3 Florian Müllner 2012-04-13 10:18:33 UTC 
Ping? This should be a very safe fix, so I'd like to get it into 3.4.1.
Comment 4 Matthias Clasen 2012-04-13 11:26:29 UTC 
yes, please
Comment 5 Rui Matos 2012-04-13 11:27:34 UTC 
Review of attachment 210484 [details] [review]:

Looks good.
Comment 6 Florian Müllner 2012-04-13 11:33:55 UTC 
Attachment 210484 [details] pushed as a2d4f13 - a11y: Set a name for the keyboard status icon

The string which is marked for translation already exists elsewhere, so I understand that the patch does not break string freeze.