After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672713 - popupMenu: make sure to break the grab when the slider is not visible
popupMenu: make sure to break the grab when the slider is not visible
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-23 19:26 UTC by Stefano Facchini
Modified: 2012-04-24 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
popupMenu: make sure to break the grab when the slider is not visible (1.33 KB, patch)
2012-03-23 19:26 UTC, Stefano Facchini
committed Details | Review

Description Stefano Facchini 2012-03-23 19:26:30 UTC
Hitting Escape while dragging the volume slider closes the menu without
ungrabbing the pointer.
Comment 1 Stefano Facchini 2012-03-23 19:26:33 UTC
Created attachment 210466 [details] [review]
popupMenu: make sure to break the grab when the slider is not visible

Otherwise the grab will persist for example after closing the PopupMenu
with Escape.
Comment 2 Giovanni Campagna 2012-03-23 19:53:55 UTC
Review of attachment 210466 [details] [review]:

Makes sense.

(The indentation is only half consistent with the rest of the file. Not a big deal)
Comment 3 Stefano Facchini 2012-04-24 21:25:32 UTC
Attachment 210466 [details] pushed as 3422e1d - popupMenu: make sure to break the grab when the slider is not visible -- with fixed indentation