After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672682 - Use FirewallD1 API
Use FirewallD1 API
Status: RESOLVED WONTFIX
Product: gnome-control-center
Classification: Core
Component: Printers
3.3.x
Other Linux
: Normal major
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-23 12:01 UTC by Marek Kašík
Modified: 2012-04-12 13:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use FirewallD1 API (19.13 KB, patch)
2012-03-23 12:01 UTC, Marek Kašík 		accepted-commit_now Details | Review

Description Marek Kašík 2012-03-23 12:01:19 UTC 
Created attachment 210406 [details] [review]
use FirewallD1 API

FirewallD1 has new API since version 2.0. Some methods were replaced (e.g. disableService -> removeService) and the philosophy was also changed a little (zones and interface were introduced to it).
The attached patch makes g-c-c to use the new API but it preserves compatibility with the old one (I would like to remove the old one in the future).

Marek

(g-c-c shows the message about missing firewalld even if firewalld-2.* is installed and running without this patch)
Comment 1 Bastien Nocera 2012-04-12 12:29:53 UTC 
Review of attachment 210406 [details] [review]:

Rest looks fine.

::: panels/printers/pp-new-printer-dialog.c
@@ +840,2 @@
                                         G_DBUS_CALL_FLAGS_NONE,
                                         60000,

Don't use magic numbers for the timeout. Either use the default timeout (-1) or define it and explain the reason for this value.
Comment 2 Marek Kašík 2012-04-12 13:52:55 UTC 
Thank you for the review. I've committed the patch downstream to Fedora since it seems that FirewallD is used just there. If there will be a request to commit it upstream then reopen this bug please.

Marek

P.S.: The support for FirewallD in gnome-control-center will be probably removed in 3.6.0 because FirewallD changed default behaviour so that it allows search for network printers in home environment by default.