GNOME Bugzilla – Bug 672671
Banshee crashes after some idle time with enabled UPnP plugin
Last modified: 2012-09-13 16:42:31 UTC
Created attachment 210395 [details] Console Output of banshee I'm using banshee 2.4.0 and mono-upnp 0.1.1, both available in Arch Linux repository. banshee crashes if you activate the UPnP plugin and after some idle time. So if you don't do anything in banshee and just wait, it crashes after a while with the attached console output. - mono-upnp is compiled with gmcs (by default from the configure script) - banshee detects following compiler in its configure scripts (by default): Mono C# Compiler: /bin/sh /build/src/banshee-2.4.0/build/m4/shave/shave mcs /usr/bin/gmcs -define:RELEASE Both packages were built with the exact same mono installation. mono-upnp-gtk is working and find some UPnP server and lists their content description and other stuff, so mono-upnp itself is working.
Forget to mention that mono is 2.10.8
Just upgraded to 2.4 on Ubuntu oneiric with Banshee's PPA and I can confirm this bug. Whenever I enable the UPnP extension, Banshee crashes *immediately* after showing the list of sharings in the source list (I can just see it appearing and then the window vanishes). The exception in the logs is a bit different. I get an server error: Unhandled Exception: Mono.Upnp.Control.UpnpControlException: The invokation failed. ---> System.Net.WebException: The remote server returned an error: (500) Internal Server Error. at System.Net.HttpWebRequest.CheckFinalStatus (System.Net.WebAsyncResult result) [0x00000] in <filename unknown>:0 at System.Net.HttpWebRequest.SetResponseData (System.Net.WebConnectionData data) [0x00000] in <filename unknown>:0 It seems like these exceptions are not handled at all.
I can also confirm the statement from Matthias Puech. I also upgraded on Ubuntu oneiric with the Banshee PPA. Banshee searches for dlna servers and then crashes as soon as it found my Minidlna share. I get the same debug output as in the attachment.
Thank you for your bug report. Daniel, could you tell me what kind of UPnP device or software you have on your network ? It look like Mono.Upnp doesn't handle correctly what the server is returning, so I'm wondering what it is. Matthias, your problem looks like a different bug. Could you please file a new bug for that ? Please also include the full log output from Banshee (instructions here: http://banshee.fm/contribute/file-bugs/) Stefan, if your output looks like the one in the first comment, you're on the right bug, if it looks like Matthias', follow him on a new bug :) In the meantime, I'll try out MiniDLNA to test it with Banshee, I didn't know about it.
Created attachment 210462 [details] Crash during UPnP server restart
I can't tell what kind of UPnP devices were on the network, I have tested this on our office network, there are lots of devices which support UPnP. I have tested it now at home. I have setup a UPnP server with ushare and banshee displays the it in the list on the left. BUT if I restart my UPnP server banshee crashes because of a WebException. I don't listen to the music from the UPnP, it's enough that the UPnP server is listed on the left and you listen to your local files. Now restart your UPnP server and banshee crashes with messages you can find in the newly created log. banshee don't crashes here if it is just idle and activated UPnP extension. But as mentioned above, banshee crashes if you just restart your UPnP server and banshee is running (no matter if you listen from the UPnP server or from your local source). There should be a better exception handling for the UPnP plugin.
Maybe some more infos. It seems that mono-upnp is very prone for not so well implemented UPnP sources. A user of Arch Linux send me this, he used the mono-upnp-gtk client to reproduce this: ----- If I select urn:schemas-upnp-org:device:InternetGateway:1 and then go to the description tag there is an entry for Icons. If you click the arrow to display the icon and the icon can't be found you'll crash. Here's the output from the crash: http://pastebin.com/TVhfw8Nt I was able to get an icon to display for my DLNA music server, but my Linksys router always causes a crash. So far the crash has only happened when I tried to display an icon it can't find, everything else seems to be working just fine. -----
Created attachment 210469 [details] banshee --debug --addin-debug ubuntu 11.10, banshee 2.4 (ppa), minidlna v1.0.19 on openwrt 10.03.1 as dlna server.
I am using minidlna (Version 1.0.19) on openwrt (backfire/10.03.1) as the dlna server and banshee 2.4 (ppa) on Ubuntu 11.10. For clarity I will add my logging as an attachment. Banshee crashes after some time when trying to list the dlna server. (when ufw is running, it does not crash - probably a rule for dlna is needed there).
I was able to reproduce the initial problem with miniDLNA, and I fixed it in Mono.Upnp with the following commit : https://github.com/mono/mono-upnp/commit/ee4f4dfdd9 We now have 2 additional and different stacktraces added to this bug, which doesn't makes things any easier to track... Please file different issues in separate bugs ! In the meantime I'll start looking into those issues.
Thanks for fixing my initial bug report. I have filed a new bug report for the problem of restarting the UPnP server and crash of banshee, you can find it here: https://bugzilla.gnome.org/show_bug.cgi?id=672744
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report. With the following commit, Banshee won't crash anymore in case of similar exceptions returned by Mono.Upnp : http://git.gnome.org/browse/banshee/commit/?id=dda96c265 So I'm marking this as fixed. Don't hesitate to file any other issues in new bugs.
*** Bug 683432 has been marked as a duplicate of this bug. ***