After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672627 - Fix PEP8 errors
Fix PEP8 errors
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-22 14:16 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2012-04-03 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PEP8: Remove trailing ; (11.94 KB, patch)
2012-03-22 14:16 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Remove spaces around = for keyword arguments (13.31 KB, patch)
2012-03-22 14:16 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: run via --fix from craigds fork (85.46 KB, patch)
2012-03-22 14:16 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Remove whitespace around {} (2.60 KB, patch)
2012-03-22 14:16 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Remove whitespace before ( (22.90 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Remove whitespace around operators (7.01 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
needs-work Details | Review
PEP8: Remove too many blank lines (1.27 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Remove too whitespace before } (851 bytes, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
needs-work Details | Review
PEP8: Add missing whitespace after : and , (6.01 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
needs-work Details | Review
PEP8: Add spaces before # (9.83 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Remaining whitespace fixes (8.58 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
Add a pep8 check to the makefile (1.36 KB, patch)
2012-03-22 14:17 UTC, Johan (not receiving bugmail) Dahlin
accepted-commit_now Details | Review
PEP8: Fix whitespace around operators (7.01 KB, patch)
2012-03-22 14:35 UTC, Johan (not receiving bugmail) Dahlin
none Details | Review

Description Johan (not receiving bugmail) Dahlin 2012-03-22 14:16:43 UTC
This patch series adds a bunch of fixes to make it PEP8 clean.
We're disabling one check (lines longer than 79 chars), but all the
others are enabled.

It also adds a check to make sure future patches also pass pep8.
Comment 1 Johan (not receiving bugmail) Dahlin 2012-03-22 14:16:48 UTC
Created attachment 210333 [details] [review]
PEP8: Remove trailing ;
Comment 2 Johan (not receiving bugmail) Dahlin 2012-03-22 14:16:51 UTC
Created attachment 210334 [details] [review]
PEP8: Remove spaces around = for keyword arguments
Comment 3 Johan (not receiving bugmail) Dahlin 2012-03-22 14:16:55 UTC
Created attachment 210335 [details] [review]
PEP8: run via --fix from craigds fork
Comment 4 Johan (not receiving bugmail) Dahlin 2012-03-22 14:16:59 UTC
Created attachment 210336 [details] [review]
PEP8: Remove whitespace around {}
Comment 5 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:03 UTC
Created attachment 210337 [details] [review]
PEP8: Remove whitespace before (
Comment 6 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:07 UTC
Created attachment 210338 [details] [review]
PEP8: Remove whitespace around operators
Comment 7 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:10 UTC
Created attachment 210339 [details] [review]
PEP8: Remove too many blank lines
Comment 8 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:14 UTC
Created attachment 210340 [details] [review]
PEP8: Remove too whitespace before }
Comment 9 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:17 UTC
Created attachment 210341 [details] [review]
PEP8: Add missing whitespace after : and ,
Comment 10 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:21 UTC
Created attachment 210342 [details] [review]
PEP8: Add spaces before #
Comment 11 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:24 UTC
Created attachment 210343 [details] [review]
PEP8: Remaining whitespace fixes
Comment 12 Johan (not receiving bugmail) Dahlin 2012-03-22 14:17:28 UTC
Created attachment 210344 [details] [review]
Add a pep8 check to the makefile

Also reorganize the pyflakes check, since target dependencies do not
take the exit status of the shell command into account.
Comment 13 Martin Pitt 2012-03-22 14:29:25 UTC
Comment on attachment 210338 [details] [review]
PEP8: Remove whitespace around operators

Actually this should sy "Fix" whitespace around operators, as in many cases they get added. Feel free to commit with that, just setting it to "needs work" to make it stand out in the attachment crowd.
Comment 14 Martin Pitt 2012-03-22 14:30:55 UTC
Comment on attachment 210340 [details] [review]
PEP8: Remove too whitespace before }

Looks fine, but please fix the grammar in the changelog (putting ", too" at the end).
Comment 15 Martin Pitt 2012-03-22 14:32:21 UTC
Comment on attachment 210341 [details] [review]
PEP8: Add missing whitespace after : and ,

--- a/demos/gtk-demo/demos/Tree View/liststore.py	
+++ b/demos/gtk-demo/demos/Tree View/liststore.py	
@@ -47,7 +47,7 @@ data = [Bug(False, 60482, "Normal",     "scrollable notebooks and hidden tabs"),
         Bug(False, 56925, "Normal",     "Gtkcalender size"),
         Bug(False, 56221, "Normal",     "Selectable label needs right-click copy menu"),
         Bug(True,  50939, "Normal",     "Add shift clicking to GtkTextView"),
-        Bug(False, 6112,  "Enhancement","netscape-like collapsable toolbars"),
+        Bug(False, 6112,  "Enhancement", "netscape-like collapsable toolbars"),

That breaks the nice alignment. Can you pleaes indent the whole second column by a space for consistency?
Comment 16 Johan (not receiving bugmail) Dahlin 2012-03-22 14:35:23 UTC
Created attachment 210345 [details] [review]
PEP8: Fix whitespace around operators
Comment 17 Johan (not receiving bugmail) Dahlin 2012-03-22 14:36:36 UTC
(In reply to comment #15)
> (From update of attachment 210341 [details] [review])
> --- a/demos/gtk-demo/demos/Tree View/liststore.py    
> +++ b/demos/gtk-demo/demos/Tree View/liststore.py    
> @@ -47,7 +47,7 @@ data = [Bug(False, 60482, "Normal",     "scrollable notebooks
> and hidden tabs"),
>          Bug(False, 56925, "Normal",     "Gtkcalender size"),
>          Bug(False, 56221, "Normal",     "Selectable label needs right-click
> copy menu"),
>          Bug(True,  50939, "Normal",     "Add shift clicking to GtkTextView"),
> -        Bug(False, 6112,  "Enhancement","netscape-like collapsable toolbars"),
> +        Bug(False, 6112,  "Enhancement", "netscape-like collapsable
> toolbars"),
> 
> That breaks the nice alignment. Can you pleaes indent the whole second column
> by a space for consistency?

All that whitespace is removed in a follow up patch...
Comment 18 Martin Pitt 2012-04-03 19:16:48 UTC
As far as I can see, all these patches are in trunk now. Thanks!