GNOME Bugzilla – Bug 672627
Fix PEP8 errors
Last modified: 2012-04-03 19:16:48 UTC
This patch series adds a bunch of fixes to make it PEP8 clean. We're disabling one check (lines longer than 79 chars), but all the others are enabled. It also adds a check to make sure future patches also pass pep8.
Created attachment 210333 [details] [review] PEP8: Remove trailing ;
Created attachment 210334 [details] [review] PEP8: Remove spaces around = for keyword arguments
Created attachment 210335 [details] [review] PEP8: run via --fix from craigds fork
Created attachment 210336 [details] [review] PEP8: Remove whitespace around {}
Created attachment 210337 [details] [review] PEP8: Remove whitespace before (
Created attachment 210338 [details] [review] PEP8: Remove whitespace around operators
Created attachment 210339 [details] [review] PEP8: Remove too many blank lines
Created attachment 210340 [details] [review] PEP8: Remove too whitespace before }
Created attachment 210341 [details] [review] PEP8: Add missing whitespace after : and ,
Created attachment 210342 [details] [review] PEP8: Add spaces before #
Created attachment 210343 [details] [review] PEP8: Remaining whitespace fixes
Created attachment 210344 [details] [review] Add a pep8 check to the makefile Also reorganize the pyflakes check, since target dependencies do not take the exit status of the shell command into account.
Comment on attachment 210338 [details] [review] PEP8: Remove whitespace around operators Actually this should sy "Fix" whitespace around operators, as in many cases they get added. Feel free to commit with that, just setting it to "needs work" to make it stand out in the attachment crowd.
Comment on attachment 210340 [details] [review] PEP8: Remove too whitespace before } Looks fine, but please fix the grammar in the changelog (putting ", too" at the end).
Comment on attachment 210341 [details] [review] PEP8: Add missing whitespace after : and , --- a/demos/gtk-demo/demos/Tree View/liststore.py +++ b/demos/gtk-demo/demos/Tree View/liststore.py @@ -47,7 +47,7 @@ data = [Bug(False, 60482, "Normal", "scrollable notebooks and hidden tabs"), Bug(False, 56925, "Normal", "Gtkcalender size"), Bug(False, 56221, "Normal", "Selectable label needs right-click copy menu"), Bug(True, 50939, "Normal", "Add shift clicking to GtkTextView"), - Bug(False, 6112, "Enhancement","netscape-like collapsable toolbars"), + Bug(False, 6112, "Enhancement", "netscape-like collapsable toolbars"), That breaks the nice alignment. Can you pleaes indent the whole second column by a space for consistency?
Created attachment 210345 [details] [review] PEP8: Fix whitespace around operators
(In reply to comment #15) > (From update of attachment 210341 [details] [review]) > --- a/demos/gtk-demo/demos/Tree View/liststore.py > +++ b/demos/gtk-demo/demos/Tree View/liststore.py > @@ -47,7 +47,7 @@ data = [Bug(False, 60482, "Normal", "scrollable notebooks > and hidden tabs"), > Bug(False, 56925, "Normal", "Gtkcalender size"), > Bug(False, 56221, "Normal", "Selectable label needs right-click > copy menu"), > Bug(True, 50939, "Normal", "Add shift clicking to GtkTextView"), > - Bug(False, 6112, "Enhancement","netscape-like collapsable toolbars"), > + Bug(False, 6112, "Enhancement", "netscape-like collapsable > toolbars"), > > That breaks the nice alignment. Can you pleaes indent the whole second column > by a space for consistency? All that whitespace is removed in a follow up patch...
As far as I can see, all these patches are in trunk now. Thanks!