GNOME Bugzilla – Bug 672616
Some messages are not marked as translatable.
Last modified: 2012-03-22 23:20:28 UTC
Created attachment 210325 [details] [review] a patch for this bug Some messages are not marked as translatable. Please look at the following patch: --- po/POTFILES.in | 1 + src/plugins/chapters/totem-edit-chapter.c | 3 ++- src/plugins/grilo/grilo.ui | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 3f4c9a8..f003bbc 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -44,6 +44,7 @@ src/plugins/brasero-disc-recorder/totem-disc-recorder.c [type: gettext/glade]src/plugins/chapters/chapters-list.ui src/plugins/chapters/totem-chapters.c src/plugins/chapters/totem-cmml-parser.c +src/plugins/chapters/totem-edit-chapter.c [type: gettext/ini]src/plugins/dbusservice/dbusservice.plugin.in src/plugins/dbusservice/dbusservice.py [type: gettext/ini]src/plugins/im-status/totem-im-status.plugin.in diff --git a/src/plugins/chapters/totem-edit-chapter.c b/src/plugins/chapters/totem-edit-chapter.c index eb81b28..ba5af5c 100644 --- a/src/plugins/chapters/totem-edit-chapter.c +++ b/src/plugins/chapters/totem-edit-chapter.c @@ -32,6 +32,7 @@ */ #include <gtk/gtk.h> +#include <glib/gi18n.h> #include "totem.h" #include "totem-interface.h" @@ -91,7 +92,7 @@ totem_edit_chapter_new (void) return NULL; } - gtk_window_set_title (GTK_WINDOW (edit_chapter), "Add Chapter"); + gtk_window_set_title (GTK_WINDOW (edit_chapter), _("Add Chapter")); gtk_dialog_add_buttons (GTK_DIALOG (edit_chapter), GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL, diff --git a/src/plugins/grilo/grilo.ui b/src/plugins/grilo/grilo.ui index e3ecda7..0bbd660 100644 --- a/src/plugins/grilo/grilo.ui +++ b/src/plugins/grilo/grilo.ui @@ -2,12 +2,12 @@ <interface> <!-- interface-requires gtk+ 3.0 --> <object class="GtkAction" id="add-to-playlist"> - <property name="label">Add to Playlist</property> + <property name="label" translatable="yes">Add to Playlist</property> <property name="tooltip">add media to playlist</property> <property name="stock_id">gtk-add</property> </object> <object class="GtkAction" id="copy-location"> - <property name="label">Copy Location</property> + <property name="label" translatable="yes">Copy Location</property> <property name="tooltip">copy media location</property> <property name="stock_id">gtk-copy</property> </object> --
After an OK by maintainers this can go in without approval as it seems they were forgotten to be marked. Notification to gnome-i18n@ is highly welcome though.
Review of attachment 210325 [details] [review]: Looks good to me. Please commit to master! Thanks.
I've pushed. http://git.gnome.org/browse/totem/commit/?id=14e4dae61302049cc62e0c8c58b169c1223d2574 Thanks!