Created attachment 210319 [details] [review]
Fix with_smclient detection

I just noticed that building evince-3.3.92 did not detect xsmp as smclient backend. After looking at the configure.ac I have found the problem due to $GDK_TARGET not checking for multiple backends:

configure.ac:

...
GDK_TARGET="$($PKG_CONFIG --variable targets gdk-3.0)"
...

AC_ARG_WITH([smclient],
  [AS_HELP_STRING([--with-smclient-backend=no|xsmp|win32|quartz],
                  [Setting smclient backend (default:auto)])],
  [],
  [case "$GDK_TARGET" in
    x11*) case "$with_platform" in
           gnome) with_smclient=xsmp ;;
           *) with_smclient=no ;;
         esac ;;
    win32|quartz) with_smclient=$GDK_TARGET ;;
    *) with_smclient=no ;;
   esac])

On my system, $GDK_TARGET reports "x11" and "broadway". Therefore the switch statement will always evaluate to false.

The attached patch fixes the issue. Please apply it before releasing evince-3.4.0.

Thanks.