GNOME Bugzilla – Bug 672608
Please add translator comment
Last modified: 2012-03-22 09:58:24 UTC
For the following string, could you please include a translator comment that explains what these sanity cleaning tasks are? #: ../data/org.gnome.Empathy.gschema.xml.in.h:9 msgid "Magic number used to check if sanity cleaning tasks should be run" Regards Kenneth
and while you are at it. Do these refer to the direction or the location? #: ../libempathy-gtk/empathy-account-widget-irc.ui.h:6 msgid "Up" #: ../libempathy-gtk/empathy-account-widget-irc.ui.h:7 msgid "Down"
Aaaand for this one. #: ../src/empathy-debug-window.c:1680 #, c-format msgid "%s" I believe it should either not be marked as translatable (if it is simply %s -> %s) or if in the case where any language is supposed to do something else, please add a comment that explains it.
Created attachment 210312 [details] [review] account-widget-irc: add translators comment on up/down tooltips
Created attachment 210313 [details] [review] debug-window: no need to translate the '%s' format
(In reply to comment #0) > For the following string, could you please include a translator comment that > explains what these sanity cleaning tasks are? > > #: ../data/org.gnome.Empathy.gschema.xml.in.h:9 > msgid "Magic number used to check if sanity cleaning tasks should be run" Those are automatic tasks which are run once to port/update account settings. Tbh, this shouldn't be exposed to users at all, I just use a gsettings key here as an optimization to only run it once. I don't think it's possible to add a translator comment from the gschema unfortunatelly. Could you please review the 2 patches above and check if that would solve your issues? Thanks!
The 2 patches look just fine. As for the last one. Since this is a gsettings key description, we don't really have any space restrictions. So how about changing the string to something like what you just explained? E.g: "Magic number used to check if tasks for porting/updating the account settings should should be run" and in the longer shorter description #: ../data/org.gnome.Empathy.gschema.xml.in.h:10 "empathy-sanity-cleaning.c uses this number to check if the porting/updating tasks for the settings should be executed or not. Users should not change this key manually." In either string you could also use only one of "porting" or "updating" if one of them describes it sufficiently.
Actually it's possible to add comments! I'll go for this so that won't break existing translations.
Created attachment 210318 [details] [review] add translator comment for the sanity-cleaning-number key
How does that look to you?
That looks good. Thanks for fixing this so quick.
Attachment 210312 [details] pushed as 26ce92a - account-widget-irc: add translators comment on up/down tooltips Attachment 210313 [details] pushed as 77f0cc3 - debug-window: no need to translate the '%s' format Attachment 210318 [details] pushed as 605f872 - add translator comment for the sanity-cleaning-number key