GNOME Bugzilla – Bug 672576
make wacom support optional
Last modified: 2012-05-17 17:34:41 UTC
Created attachment 210265 [details] [review] make wacom support optional Recently g-s-d got a hard dependency on the development files from the wacom xorg driver, but those files don't exist on all architectures (eg. s390). See attached patch for a fix.
Created attachment 210266 [details] [review] update for Fedora spec file
What's the reason why it doesn't exist on s390? The development files could exist just as well on s390. In any case, I'm not taking those patches to make it optional.
They can't exist because the xorg server SDK is not built there, and the SDK is not built because no hardware drivers are built in the xserver, if I understand the dependencies correctly. And additionally you can't connect any wacom tablet to s390 and this won't change. Adding the possibility to build without the wacom support was pre-acknowledged by mclasen.
And optional here means it can be disabled and is required by default.
(In reply to comment #3) > They can't exist because the xorg server SDK is not built there, and the SDK is > not built because no hardware drivers are built in the xserver, if I understand > the dependencies correctly. And additionally you can't connect any wacom tablet > to s390 and this won't change. Then make it disabled automatically on s390. I don't want it to be an option, and I want builds to fail on every other platform which has the header missing. > Adding the possibility to build without the wacom support was pre-acknowledged > by mclasen. Matthias isn't the maintainer of gnome-settings-daemon :)
(In reply to comment #5) > (In reply to comment #3) > > They can't exist because the xorg server SDK is not built there, and the SDK is > > not built because no hardware drivers are built in the xserver, if I understand > > the dependencies correctly. And additionally you can't connect any wacom tablet > > to s390 and this won't change. > > Then make it disabled automatically on s390. I don't want it to be an option, > and I want builds to fail on every other platform which has the header missing. Uff, I don't understand now, I think the patch does exactly this. Unless --disable-wacom is specified, it fails the build when all requirements are not met. > > Adding the possibility to build without the wacom support was pre-acknowledged > > by mclasen. > > Matthias isn't the maintainer of gnome-settings-daemon :) I know, but you was on vacation when I had to come with a solution to move fedora/s390x further.
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > They can't exist because the xorg server SDK is not built there, and the SDK is > > > not built because no hardware drivers are built in the xserver, if I understand > > > the dependencies correctly. And additionally you can't connect any wacom tablet > > > to s390 and this won't change. > > > > Then make it disabled automatically on s390. I don't want it to be an option, > > and I want builds to fail on every other platform which has the header missing. > > Uff, I don't understand now, I think the patch does exactly this. Unless > --disable-wacom is specified, it fails the build when all requirements are not > met. Replace the user given "--disable-wacom" with a hard-coded check for s390, and I'm fine with it.
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #3) > > > > They can't exist because the xorg server SDK is not built there, and the SDK is > > > > not built because no hardware drivers are built in the xserver, if I understand > > > > the dependencies correctly. And additionally you can't connect any wacom tablet > > > > to s390 and this won't change. > > > > > > Then make it disabled automatically on s390. I don't want it to be an option, > > > and I want builds to fail on every other platform which has the header missing. > > > > Uff, I don't understand now, I think the patch does exactly this. Unless > > --disable-wacom is specified, it fails the build when all requirements are not > > met. > > Replace the user given "--disable-wacom" with a hard-coded check for s390, and > I'm fine with it. Thanks, understood, stay tuned :-)
Created attachment 210639 [details] [review] disable wacom for s390(x)
Pushed, with the addition of a print at the end of the configure for the state of the option
*** Bug 674625 has been marked as a duplicate of this bug. ***
Comment on attachment 210639 [details] [review] disable wacom for s390(x) Pushed to gnome-3-4 as well