Bug 672567 - Launching of new machines not working
Launching of new machines not working
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-03-21 16:22 UTC by Zeeshan Ali (Khattak)
Modified: 2016-03-31 14:01 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simplify creation of VMs a bit (4.12 KB, patch)
2012-03-21 16:22 UTC, Zeeshan Ali (Khattak) 		committed Details | Diff | Review
Wait for right state before selecting new machine (1.33 KB, patch)
2012-03-21 16:22 UTC, Zeeshan Ali (Khattak) 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Zeeshan Ali (Khattak) 2012-03-21 16:22:29 UTC 
The code to select and fullscreen our own created libvirt machines was not working (reliably at least). Attached patches fixes that.
Comment 1 Zeeshan Ali (Khattak) 2012-03-21 16:22:31 UTC 
Created attachment 210256 [details] [review]
Simplify creation of VMs a bit
Comment 2 Zeeshan Ali (Khattak) 2012-03-21 16:22:35 UTC 
Created attachment 210257 [details] [review]
Wait for right state before selecting new machine

We were trying to select the machine soon after creation without waiting
for UI state to change to 'collection' and App.select_item() was simply
failing since UI state was still 'wizard'.
Comment 3 Marc-Andre Lureau 2012-04-13 13:05:45 UTC 
Review of attachment 210256 [details] [review]:

ack
Comment 4 Marc-Andre Lureau 2012-04-13 13:06:27 UTC 
Review of attachment 210257 [details] [review]:

ack
Comment 5 Zeeshan Ali (Khattak) 2012-04-13 13:32:41 UTC 
Attachment 210256 [details] pushed as 3081634 - Simplify creation of VMs a bit
Attachment 210257 [details] pushed as 591cfe4 - Wait for right state before selecting new machine
Note You need to log in before you can comment on or make changes to this bug.