After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672508 - "Advanced" scrolled window does not have border
"Advanced" scrolled window does not have border
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-20 22:30 UTC by Cosimo Cecchi
Modified: 2012-03-21 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (19.93 KB, image/png)
2012-03-20 22:30 UTC, Cosimo Cecchi 		  Details
account-widget: set shadow_type=in for advanced scrolled windows (2.45 KB, patch)
2012-03-20 23:36 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-03-20 22:30:18 UTC 
See attached screenshot; the scrolled window could use gtk_scrolled_window_set_shadow_type(sw, GTK_SHADOW_IN). Also, when the expander is expanded, the resulting section is really small; not sure if that's a bug in the GtkExpander logic or if we can tweak some fill/expand packing property to change this behavior.
Comment 1 Cosimo Cecchi 2012-03-20 22:30:40 UTC 
Created attachment 210209 [details]
screenshot
Comment 2 Cosimo Cecchi 2012-03-20 23:36:15 UTC 
Created attachment 210211 [details] [review]
account-widget: set shadow_type=in for advanced scrolled windows
Comment 3 Guillaume Desmottes 2012-03-21 09:56:02 UTC 
Review of attachment 210211 [details] [review]:

++
Comment 4 Guillaume Desmottes 2012-03-21 09:56:41 UTC 
Btw do you know why the background is white? Any idea how to fix that as well?
Comment 5 Guillaume Desmottes 2012-03-21 09:59:05 UTC 
(In reply to comment #0)
> Also, when the expander
> is expanded, the resulting section is really small; not sure if that's a bug in
> the GtkExpander logic or if we can tweak some fill/expand packing property to
> change this behavior.


Setting 'expand' to TRUE in vbox_advanced doesn't help so yeah, that may be a Gtk+ issue.
Comment 6 Cosimo Cecchi 2012-03-21 14:30:07 UTC 
(In reply to comment #4)
> Btw do you know why the background is white? Any idea how to fix that as well?

The white background is set by the theme, so you don't have to do anything here I think.
Comment 7 Cosimo Cecchi 2012-03-21 15:55:57 UTC 
Attachment 210211 [details] pushed as f7dbe93 - account-widget: set shadow_type=in for advanced scrolled windows

Pushed to master with r-t approval