GNOME Bugzilla – Bug 672500
[PATCH] Make it easier to monkey patch a new calendar source
Last modified: 2014-11-07 14:04:28 UTC
The attached patch makes it easier to monkey patch the calendar at the top of the shell to retrieve information from other sources. The use case is to provide a way for third party calendar applications to control the events that show up, rather than e-d-s. Personally I need it for «Day Planner», which is desktop agnostic, but I'd still like to provide good integration with GNOME. If the attached patch gets applied I could write a shell extension that monkey patches a custom source onto the calendar. Given that the «official» API for integration most likely is e-d-s, this can provide a way for those that won't (or can't) use e-d-s to integrate with the shell without having to reimplement/copy the entire calendar source.
Created attachment 210202 [details] [review] Patch for dateMenu.js
Review of attachment 210202 [details] [review]: Please provide a proper patch with a subject and commit message (using git format-patch).
Created attachment 210221 [details] [review] Allow extensions to add custom calendar sources Properly formatted patch
Review of attachment 210221 [details] [review]: Very minor issue, otherwise fine. ::: js/ui/dateMenu.js @@ +46,3 @@ Extends: PanelMenu.Button, + _getEventSource: function() { This should go below _init.
Created attachment 290164 [details] [review] dateMenu: Allow extensions to add custom calendar sources Splits instantiation of the event source into a separate method, allowing extensions to subclass the DateMenuButton and provide its own calendar source.
Review of attachment 290164 [details] [review]: Ok
Attachment 290164 [details] pushed as 35fcd16 - dateMenu: Allow extensions to add custom calendar sources