After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672483 - ephy-completion-model: minor cleanup
ephy-completion-model: minor cleanup
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-20 16:05 UTC by Claudio Saavedra
Modified: 2012-03-21 08:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-completion-model: minor cleanup (1.17 KB, patch)
2012-03-20 16:05 UTC, Claudio Saavedra
committed Details | Review

Description Claudio Saavedra 2012-03-20 16:05:01 UTC
No need to invoke twice webkit_get_favicon_databas() in the same
method, there's a variable pointing to the database already.
Comment 1 Claudio Saavedra 2012-03-20 16:05:03 UTC
Created attachment 210188 [details] [review]
ephy-completion-model: minor cleanup

No need to invoke twice webkit_get_favicon_databas() in the same
method, there's a variable pointing to the database already.
Comment 2 Xan Lopez 2012-03-20 17:53:57 UTC
Review of attachment 210188 [details] [review]:

OK.
Comment 3 Claudio Saavedra 2012-03-21 08:21:20 UTC
Attachment 210188 [details] pushed as e1b810c - ephy-completion-model: minor cleanup