After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672480 - ephy-history-window: add back the favicons
ephy-history-window: add back the favicons
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-20 15:56 UTC by Claudio Saavedra
Modified: 2012-03-21 08:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-history-window: add back the favicons (6.32 KB, patch)
2012-03-20 15:56 UTC, Claudio Saavedra 		none Details | Review
ephy-history-window: add back the favicons (6.36 KB, patch)
2012-03-20 16:00 UTC, Claudio Saavedra 		committed Details | Review

Description Claudio Saavedra 2012-03-20 15:56:13 UTC 
Use the new webkit favicon database for favicons here. This
might not work perfectly, but that's a webkitgtk issue, see
https://bugs.webkit.org/show_bug.cgi?id=81665
Comment 1 Claudio Saavedra 2012-03-20 15:56:15 UTC 
Created attachment 210184 [details] [review]
ephy-history-window: add back the favicons
Comment 2 Claudio Saavedra 2012-03-20 16:00:50 UTC 
Created attachment 210185 [details] [review]
ephy-history-window: add back the favicons

Use the new webkit favicon database for favicons here. This
might not work perfectly, but that's a webkitgtk issue, see
https://bugs.webkit.org/show_bug.cgi?id=81665
Comment 3 Xan Lopez 2012-03-20 17:59:14 UTC 
Review of attachment 210185 [details] [review]:

OK.

::: lib/widgets/ephy-hosts-store.c
@@ +109,2 @@
     gtk_list_store_insert_with_values (GTK_LIST_STORE (store),
+                                       &treeiter, G_MAXINT,

This seems like a bug that was there before? :)
Comment 4 Claudio Saavedra 2012-03-21 08:51:23 UTC 
Attachment 210185 [details] pushed as 733bf55 - ephy-history-window: add back the favicons