GNOME Bugzilla – Bug 672445
map widget does not look insensitive when the panel is locked
Last modified: 2012-09-03 16:21:25 UTC
Created attachment 210150 [details] screenshot of the locked date and time panel See the attached screenshot - it looks like you can interact with the map, even though you can't.
*** Bug 682399 has been marked as a duplicate of this bug. ***
Created attachment 222096 [details] [review] datetime: make the map insensitive when the panel is locked
Review of attachment 222096 [details] [review]: We should probably simply use gtk_render_icon() in draw() instead, meaning that it would automatically follow the state of the widget. See: http://git.gnome.org/browse/gtk+/tree/gtk/gtkimage.c#n1369
(In reply to comment #3) > We should probably simply use gtk_render_icon() in draw() instead, meaning that > it would automatically follow the state of the widget. > See: http://git.gnome.org/browse/gtk+/tree/gtk/gtkimage.c#n1369 gtk_render_icon() does no such magic; the reason why it works in GtkImage is because GtkIconHelper ensures a stated pixbuf when creating it from the GIcon or icon_name descriptions [1] - it doesn't do it if you e.g. set a GdkPixbuf yourself on the GtkImage. Also, those functions are really targeted towards icons (gtk_render_icon() will e.g. apply CSS shadows); I think shipping a different set of images altogether here is a fine solution. [1] http://git.gnome.org/browse/gtk+/tree/gtk/gtkiconhelper.c#n185
Bastien, given the information in comment 4, can we commit this as-is ?
(In reply to comment #5) > Bastien, given the information in comment 4, can we commit this as-is ? Yep, fine by me.
Created attachment 223344 [details] how it looks
The following fix has been pushed: 0703d54 datetime: make the map insensitive when the panel is locked
Created attachment 223345 [details] [review] datetime: make the map insensitive when the panel is locked