After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672434 - about dialog says GNOME Documents but name is Documents
about dialog says GNOME Documents but name is Documents
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-03-20 04:51 UTC by William Jon McCann
Modified: 2012-04-19 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Title of application "Gnome-Documents" instead of "Documents" (9.18 KB, patch)
2012-04-04 14:35 UTC, Anna Zacchi
rejected Details | Review
Change to About Dialog (1.21 KB, patch)
2012-04-04 19:26 UTC, Anna Zacchi
needs-work Details | Review
From "GNOME Documents" to "Documents" (1.07 KB, patch)
2012-04-04 20:25 UTC, Anna Zacchi
committed Details | Review

Description William Jon McCann 2012-03-20 04:51:19 UTC
The about dialog says GNOME Documents but the user visible name is just Documents.
Comment 1 Anna Zacchi 2012-04-04 05:33:48 UTC
By "the user visible name" do you mean the title in the title bar of the application?
Comment 2 Cosimo Cecchi 2012-04-04 14:07:24 UTC
(In reply to comment #1)
> By "the user visible name" do you mean the title in the title bar of the
> application?

No, this refers to the bold label in the dialog reachable by clicking on "About Documents" in the application menu.
Comment 3 Anna Zacchi 2012-04-04 14:35:29 UTC
Created attachment 211299 [details] [review]
Title of application "Gnome-Documents" instead of "Documents"
Comment 4 Cosimo Cecchi 2012-04-04 16:52:44 UTC
(In reply to comment #3)
> Created an attachment (id=211299) [details] [review]
> Title of application "Gnome-Documents" instead of "Documents"

Hey Anna! Patches should be attached to bug reports in a diff format; you can use `git diff` to get a diff between the current state of the code and the last commit in the branch, or `git format-patch` to turn a git commit itself into a patch.
You can also use git-bz [1], which is a nice tool designed to make it easy to interact with bugzilla reports from a git repo.

As for the code itself, I think you got the intent of this bug report backwards; right now we show 'Documents' as an application name everywhere except for the aforementioned string in the About dialog. That string should be modified to read "Documents" too, instead of "GNOME Documents".

[1] http://fishsoup.net/software/git-bz/
Comment 5 Anna Zacchi 2012-04-04 19:26:08 UTC
Created attachment 211322 [details] [review]
Change to About Dialog
Comment 6 Cosimo Cecchi 2012-04-04 20:02:08 UTC
Review of attachment 211322 [details] [review]:

Getting better! I have a comment on this patch below.

::: src/mainWindow.js
@@ -251,3 @@
                                 'William Jon McCann <william.jon.mccann@gmail.com>' ];
         aboutDialog.translator_credits = _("translator-credits");
-        aboutDialog.program_name = _("Gnome-Documents");

You seem to change the string from "Gnome-Documents" to "Documents" in the patch, but the current string in git master is "GNOME Documents". Are you sure the patch you published is not actually applied on top on another modification you did previously?
Comment 7 Anna Zacchi 2012-04-04 20:25:17 UTC
Created attachment 211340 [details] [review]
From "GNOME Documents" to "Documents"
Comment 8 Cosimo Cecchi 2012-04-04 20:34:28 UTC
Review of attachment 211340 [details] [review]:

Yes, thanks! Looks good!

Since this touches an user visible string, we should hold on committing this to git master until after I branch the application for the new 3.6 development cycle.
Comment 9 Cosimo Cecchi 2012-04-19 14:24:24 UTC
This is now pushed to master.