GNOME Bugzilla – Bug 672431
the alt+tab app switch makes mnemonics flash
Last modified: 2012-09-01 02:53:19 UTC
I use alt+tab a lot. And quite often the window I'm currently in has alt mnemonics "_" that show up right as I'm about to switch away from the app. It is really annoying and distracting. Not calming.
Yep, it does. Do you have suggestions about how it should behave?
Perhaps only show the mnemonics after a small delay? The idea being that you are trying to discover something and aren't sure... hence pause for a second.
Created attachment 221942 [details] [review] window: Add a delay before automatically showing mnemonics Showing mnemonics immediately on modifier press can be annoying and distracting when the user is just trying to Alt+Tab into another application/window since the mnemonic will show up and quickly vanish again when we receive the focus out event. -- Here's a simple patch implementing the suggested behavior. Do we want to make the delay configurable e.g. through GtkSettings?
Bug 681876 is related
Review of attachment 221942 [details] [review]: You need to remove the timeout in gtk_window_finalize too, I'd say. ::: gtk/gtkwindow.c @@ +99,3 @@ */ +#define AUTO_MNEMONICS_DELAY 500 /* ms */ This feels a little slow to me as the default. 250 or 300 is still more than enough to avoid Alt-Tab flicker. You are probably right that it needs to be exposed as a setting. I'd be tempted to tie it to the key-repeat delay on the settings-daemon side. @@ +9786,3 @@ + + window->priv->auto_mnemonics_timeout_id = + g_timeout_add (AUTO_MNEMONICS_DELAY, set_auto_mnemonics_visible_cb, window); Should use gdk_threads_add_timeout, as long as we still have the lock
Created attachment 222629 [details] [review] window: Add a delay before automatically showing mnemonics -- (In reply to comment #5) > You need to remove the timeout in gtk_window_finalize too, I'd say. Ups, fixed. > ::: gtk/gtkwindow.c > @@ +99,3 @@ > */ > > +#define AUTO_MNEMONICS_DELAY 500 /* ms */ > > This feels a little slow to me as the default. > 250 or 300 is still more than enough to avoid Alt-Tab flicker. Changed to 300. > You are probably right that it needs to be exposed as a setting. > I'd be tempted to tie it to the key-repeat delay on the settings-daemon side. Since a better fix is to probably have mnemonics disabled by default as McCann says, let's just leave it hardcoded for now. > @@ +9786,3 @@ > + > + window->priv->auto_mnemonics_timeout_id = > + g_timeout_add (AUTO_MNEMONICS_DELAY, set_auto_mnemonics_visible_cb, > window); > > Should use gdk_threads_add_timeout, as long as we still have the lock Sure.
The following fix has been pushed: ed7a417 window: Add a delay before automatically showing mnemonics
Created attachment 223117 [details] [review] window: Add a delay before automatically showing mnemonics Showing mnemonics immediately on modifier press can be annoying and distracting when the user is just trying to Alt+Tab into another application/window since the mnemonic will show up and quickly vanish again when we receive the focus out event.