After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672430 - rounded top corners of maximized windows doesn't fit well with toolbar buttons
rounded top corners of maximized windows doesn't fit well with toolbar buttons
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 672278 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-03-20 03:52 UTC by William Jon McCann
Modified: 2012-05-07 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (28.42 KB, image/png)
2012-03-20 03:52 UTC, William Jon McCann 		  Details
6px top bar radius (41.10 KB, image/png)
2012-03-21 13:03 UTC, Jakub Steiner 		  Details
use 6px radius instead of 10px for top bar (2.00 KB, patch)
2012-03-21 15:04 UTC, Jakub Steiner 		none Details | Review
gtk toolbar padding uniform in horizontal and vertical direction (816 bytes, patch)
2012-03-26 18:51 UTC, Jakub Steiner 		none Details | Review

Description William Jon McCann 2012-03-20 03:52:43 UTC 
Created attachment 210138 [details]
screenshot

If you look at the top left and right corners of the app window in the attached screenshot you may notice that the curvature of the shell top bar that is imposed on the window doesn't interact nicely with the curvature of the toolbar buttons and the border padding within the toolbar.

You have two curves with different radii and top, bottom, and left/right paddings that are not consistent.
Comment 1 Rui Matos 2012-03-20 11:13:46 UTC 
I agree, but what should be done about it? Is the problem in the shell, on the apps or on both?
Comment 2 Allan Day 2012-03-20 16:27:05 UTC 
Might be worth thinking about bug 643204 at the same time.
Comment 3 Jakub Steiner 2012-03-21 12:47:29 UTC 
While this doesn't address the padding in the toolbar itself, having -panel-corner-radius: 6px instead of the current 10px plays well with the toolbar buttons and the window titlebar. It creates a gap for the :active activities button border though, so Florian needs to look into this.
Comment 4 Jakub Steiner 2012-03-21 12:48:30 UTC 
*** Bug 672278 has been marked as a duplicate of this bug. ***
Comment 5 Jakub Steiner 2012-03-21 13:03:24 UTC 
Created attachment 210229 [details]
6px top bar radius

As indicated by the red dots, the vertical padding is still a pixel smaller than horizontal.
Comment 6 Jakub Steiner 2012-03-21 13:05:53 UTC 
Err, 2px.
Comment 7 Jakub Steiner 2012-03-21 15:04:21 UTC 
Created attachment 210248 [details] [review]
use 6px radius instead of 10px for top bar

Patch courtesy of Florian Muellner.
Comment 8 Jakub Steiner 2012-03-26 18:51:41 UTC 
Created attachment 210653 [details] [review]
gtk toolbar padding uniform in horizontal and vertical direction

This is the gtk part of the fix. Toolbars having a uniform 4px H/V padding.
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-05-02 20:24:13 UTC 
Is this ready for inclusion, Jakub?
Comment 10 Jakub Steiner 2012-05-06 11:42:47 UTC 
It looks decent from my POV.
Comment 11 Jasper St. Pierre (not reading bugmail) 2012-05-06 16:31:15 UTC 
We don't require patch review for CSS changes, so go ahead and push if you want to.
Comment 12 Jakub Steiner 2012-05-07 08:40:49 UTC 
Pushed to gnome-themes-standard and gnome-shell master.