GNOME Bugzilla – Bug 672420
express,fedora: Install latest packages from repo
Last modified: 2016-03-31 13:55:41 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=804834
Created attachment 210133 [details] [review] express,fedora: Install latest packages from repo Not sure if this is a good thing in general but this is the quickest solution to this bug I could come-up with: https://bugzilla.redhat.com/show_bug.cgi?id=804834 The main issue with this change is that it makes Fedora express installation to require Internet access.
Review of attachment 210133 [details] [review]: 2 remarks: - we should only require internet connection during install to workaround f16 or broken guests, not f17 - if possible, it would make sense to selectively update what is needed for boxes to work properly (qxl driver in this case, perhaps agent too etc..)
(In reply to comment #2) > Review of attachment 210133 [details] [review]: > > 2 remarks: > - we should only require internet connection during install to workaround f16 > or broken guests, not f17 Agreed. > - if possible, it would make sense to selectively update what is needed for > boxes to work properly (qxl driver in this case, perhaps agent too etc..) I wanted to do that but I dont see any straight-forward way to do that :( http://fedoraproject.org/wiki/Anaconda/Kickstart#repo We better just use remote repos for <= F16 and install vdagent as well as its going to be available in F17 (and beyond) install medias: https://bugzilla.redhat.com/show_bug.cgi?id=804739
Created attachment 210203 [details] [review] express,fedora: Install from remote repo for <= F16 Not sure if this is a good thing in general but this is the quickest solution to this bug I could come-up with: https://bugzilla.redhat.com/show_bug.cgi?id=804834 One issue with this change is that it makes Fedora 16 (and older) express installation to require Internet access. On the bright side, we can now have spice-vdagent package installed automatically from the start.
Review of attachment 210203 [details] [review]: looks good,
Comment on attachment 210203 [details] [review] express,fedora: Install from remote repo for <= F16 Committed as d621682 (to 3.5.x branch because of code freeze).
You forgot to fix + // FIXME: Mark for translation after string freeze + var message = "Internet access required for express installation of Fedora 16 and older"; This should be ok to do since it's in a separate branch that won't be merged before 3.4.0
(In reply to comment #7) > You forgot to fix > + // FIXME: Mark for translation after string freeze > + var message = "Internet access required for express installation > of Fedora 16 and older"; > This should be ok to do since it's in a separate branch that won't be merged > before 3.4.0 Not entirely true. I will be cherry-picking all essential fixes to master once hard code freeze is over. So far, it seems like I will be cherr-picking everything from this branch..
If master is what you will use for 3.4.x releases, the string should be marked for translation and a string freeze break requested. The string freeze is still in effect after 3.4.0 is released, and adding a new user-visible string is a string freeze break even if you don't mark it for translation for now. The goal of the string freeze is to help translators get an application where all user-visible strings are translated.
(In reply to comment #9) > If master is what you will use for 3.4.x releases, the string should be marked > for translation and a string freeze break requested That is, when/if you merge this patch to master and want to make a 3.4.x release with this in.