After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672417 - Fix deprecations and file warnings
Fix deprecations and file warnings
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-20 00:23 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-03-23 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fail-whale: Don't use deprecated API (2.10 KB, patch)
2012-03-20 00:23 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
manager: Fix compile warning (1.30 KB, patch)
2012-03-20 00:23 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-03-20 00:23:43 UTC 
See patches
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-20 00:23:44 UTC 
Created attachment 210127 [details] [review]
fail-whale: Don't use deprecated API
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-20 00:23:46 UTC 
Created attachment 210128 [details] [review]
manager: Fix compile warning
Comment 3 Vincent Untz 2012-03-21 10:52:52 UTC 
Review of attachment 210127 [details] [review]:

Assuming my guess is right, please commit after hard code freeze.

::: gnome-session/gsm-fail-whale-dialog.c
@@ -189,3 @@
-            gtk_widget_get_visible (gtk_bin_get_child (bin))) {
-                gtk_widget_size_request (gtk_bin_get_child (bin), requisition);
-        }

I guess this was used for the list of extensions, right?
Comment 4 Vincent Untz 2012-03-21 10:53:22 UTC 
Review of attachment 210128 [details] [review]:

Please commit after hard code freeze.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-03-23 09:51:03 UTC 
Attachment 210127 [details] pushed as ad6d425 - fail-whale: Don't use deprecated API
Attachment 210128 [details] pushed as 1313fbb - manager: Fix compile warning