GNOME Bugzilla – Bug 672405
'source-url' set on single image files causes problems
Last modified: 2016-04-20 15:16:38 UTC
gnome-control-center sets the "source-url" property on any 'single file' background (ie: one that is added to the control panel via the file chooser after clicking the [+] button). this has a few bad effects. the main one is that it causes the control center to believe that it has to "download" the file. this causes it to create a filename under ~/.cache/ and copy the file to it. that makes sense of the file was originally on a remote gvfs volume (sftp, http), but the file chooser in question doesn't even let you select non-local files. this causes a few problems: 1) wasted disk space 2) the picture-uri set in gsettings is not the one the user picked 3) (caused by 2) when you come back to the panel later and reselect the same picture, you see the checksum blob instead of the proper filename
Created attachment 210097 [details] [review] background: don't 'download' image files The code for downloading files from remote uris was being triggered in the case of adding a background image file via the file chooser. Don't set the 'source-url' attribute on the image in this case in order to avoid the problem.
Review of attachment 210097 [details] [review]: As discussed on IRC, the goal should be: - downloading directly in ~/Pictures with a nice name - adding hoopses for deleting all the pictures (confirmation?), or maybe just the pictures we didn't cache/download
The Background panel doesn't have a file chooser any more.
From #control-center on GIMPNet: 14:55 <rishi> hadess: RESOLVED OBSOLETE: https://bugzilla.gnome.org/show_bug.cgi?id=672405 ? 14:56 <hadess> i guess so