GNOME Bugzilla – Bug 672376
Distracting hover state for partition icons
Last modified: 2012-03-20 16:47:56 UTC
Created attachment 210072 [details] Disks with cursor hovering over a selected partition Near the label for each partition in Disks 3.3.93, there are icons to describe its state. (For example, a Play icon to indicate that it is in use). These icons are generally the same colour as the text. So, if I select a partition and the text turns white, the icons follow. However, as long as the mouse hovers over that selected partition, the icons are still dark grey. It draws a lot of attention to these icons and it gives an impression that they are somehow interactive, which they are not.
Yeah, I've been talking to Cosimo about this on and off the past couple of months... and I think we agreed that it was either a theme bug or that we needed some custom CSS or revisit how GduVolumeGrid works. Cosimo? Btw, I saw a similar problem with Nautilus, see http://people.freedesktop.org/~david/nautilus-dark-grey-bug.png
I think there are two bugs here: - a theme bug, which was missing a selector to ensure icons with a selected state get the right color (i.e. equal to the text color), which I now fixed in http://git.gnome.org/browse/gnome-themes-standard/commit/?id=ebf5f3d3766b83002f8adada0a5d26a933a13b65 - a GduVolumeGrid bug, which shouldn't set a prelight state if it doesn't allow actions on click. I will attach a patch for this in a followup comment.
Created attachment 210105 [details] [review] volume-grid: don't set the PRELIGHT state flag Since items on the grid are not actionable on click, but with the toolbar below, the hover state is just potentially confusing.
(In reply to comment #2) > - a GduVolumeGrid bug, which shouldn't set a prelight state if it doesn't allow > actions on click. I will attach a patch for this in a followup comment. But the tree view widget uses prelight.. or at least it used to.. appears it doesn't do it anymore... did this recently change? Thanks!
(In reply to comment #2) > I think there are two bugs here: > > - a theme bug, which was missing a selector to ensure icons with a selected > state get the right color (i.e. equal to the text color), which I now fixed in > http://git.gnome.org/browse/gnome-themes-standard/commit/?id=ebf5f3d3766b83002f8adada0a5d26a933a13b65 Confirmed, this fixes the bug - thanks! > - a GduVolumeGrid bug, which shouldn't set a prelight state if it doesn't allow > actions on click. I will attach a patch for this in a followup comment. Committed this one too http://git.gnome.org/browse/gnome-disk-utility/commit/?id=2a2af2a3294a643d82faf0a48af35d622722faf6 Thanks!