After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672337 - fails to parse slides with speaker notes right below the slide delimiter
fails to parse slides with speaker notes right below the slide delimiter
Status: RESOLVED WONTFIX
Product: pinpoint
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Pinpoint maintainer(s)
Pinpoint maintainer(s)
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2012-03-18 12:03 UTC by Antonio Terceiro
Modified: 2018-08-17 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix parsing comments right below slide delimiter (759 bytes, patch)
2012-03-18 12:06 UTC, Antonio Terceiro
none Details | Review

Description Antonio Terceiro 2012-03-18 12:03:24 UTC
sometimes you want to have a slide with a picture with no text at all, and have some speaker notes to remember what you have to say at that point.

but if the speaker notes come right below the slide delimiter, pinpoint fails to parse them and add the first line of speaker as if they were slide text.

For example, in the following slide, pinpoint would put "# cat" as the slide text, and just the second line as the actual speaker notes.

--------------------------8<------------------------
-- [linus.jpg]
# a cat
# everybody loves cats, right?
--------------------------8<------------------------

A workaround is adding a blank line between slide delimiter and comments, but that breaks the possibility to have them close to each other as a unique block.

--------------------------8<------------------------
-- [linus.jpg]

# a cat
# everybody loves cats, right?
--------------------------8<------------------------

the problem is that the code that parses the slide delimiter line sets startofline to FALSE, even though it actually consumes the current line through its end and the next character that will be read actualy *is* the first of its line.
Comment 1 Antonio Terceiro 2012-03-18 12:06:55 UTC
Created attachment 210043 [details] [review]
Fix parsing comments right below slide delimiter
Comment 2 Lionel Landwerlin 2012-05-30 22:06:36 UTC
The patch has been committed upstream, please close the bug.
Comment 3 André Klapper 2018-08-17 19:57:25 UTC
pinpoint is not under active development anymore since 2015.
Its codebase has been archived:
https://gitlab.gnome.org/Archive/pinpoint/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.