Bug 672332 – cr-rgb: Fix mapping for 'green'

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 672332 - cr-rgb: Fix mapping for 'green'


Summary:	cr-rgb: Fix mapping for 'green'


Status:	RESOLVED FIXED

Product:	libcroco
Classification:	Core
Component:	General
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	libcroco maintainers
QA Contact:	libcroco maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-03-18 10:46 UTC by drago01
Modified:	2013-04-02 09:55 UTC

See Also:	https://bugzilla.wikimedia.org/show_bug.cgi?id=46540
GNOME target:	---
GNOME version:	---

Attachments
cr-rgb: Fix mapping for 'green' (1.22 KB, patch) 2012-03-18 10:46 UTC, drago01	committed	Details \| Review

Description drago01 2012-03-18 10:46:44 UTC

See patch.

Comment 1 drago01 2012-03-18 10:46:47 UTC

Created attachment 210039 [details] [review]
cr-rgb: Fix mapping for 'green'

Green is supposed to be #00FF00 not #008000.

Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-18 10:53:19 UTC

(In reply to comment #1)
> Created an attachment (id=210039) [details] [review]
> cr-rgb: Fix mapping for 'green'
> 
> Green is supposed to be #00FF00 not #008000.

We should probably just port croco over to pango_color_parse rather than maintaining two color maps.

Comment 3 drago01 2012-03-18 11:55:14 UTC

Attachment 210039 [details] pushed as 0cbb0df - cr-rgb: Fix mapping for 'green'

Comment 4 Petr Kadlec 2013-03-29 13:18:57 UTC

This bug/request is invalid, “green” in CSS _should be_ indeed #008000, not #00FF00, see http://www.w3.org/TR/CSS2/syndata.html#color-units.

The change was already reverted in https://git.gnome.org/browse/libcroco/commit/?id=b37d79049a0f9149df98e5adb4f69db69deef056 so I guess this bug should be reopened and then RESOLVED as NOTABUG/INVALID, not FIXED (for which I do not have permissions to do myself, it seems?).

Comment 5 Jasper St. Pierre (not reading bugmail) 2013-03-29 14:33:11 UTC

(In reply to comment #4)
> I guess this bug should be reopened and then RESOLVED as NOTABUG/INVALID,
> not FIXED (for which I do not have permissions to do myself, it seems?).

Nobody cares enough to do that.