After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672296 - Evince docs uses wrong key sequence markup
Evince docs uses wrong key sequence markup
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: User documentation
git master
Other All
: Normal minor
: ---
Assigned To: Reinout van Schouwen
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-17 14:37 UTC by Rudolfs Mazurs
Modified: 2012-03-18 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Rudolfs Mazurs 2012-03-17 14:37:04 UTC 
In evince documentation there are cases of something like
<key>Ctrl</key>+ Left Click
where there should be
<keyseq><key>Ctrl</key> Left Click</keyseq>

These types of mistakes are in:
C/synctex-search.page:40
C/synctex-search.page:65
C/synctex.page:30

Also, in C/presentations.page:40 there is a string
"Use the <key>spacebar</key>, right arrow key, down arrow key, or left mouse click to go to the next slide.". Does mallard support special markup for arrow keys?
Comment 1 Tiffany Antopolski 2012-03-18 05:31:32 UTC 
The tag <keyseq> should contain a sequence of <key> tags representing keypresses.  A left click is not a keypress and therefore can't be in the <key> tag.

<keyseq><key>Ctrl</key> Left Click</keyseq> is not be valid Mallard markup.
Comment 2 Tiffany Antopolski 2012-03-18 05:50:52 UTC 
Markup for arrow keys fixed:  http://git.gnome.org/browse/evince/commit/?id=9f5cc57eed3155841bf0d321bc10586a3709b838

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Rudolfs Mazurs 2012-03-18 08:35:34 UTC 
If mouse clicks are not part of key sequences, please update the mallard documentation:
http://projectmallard.org/1.0/mal_inline_keyseq.html
specifically point 3.

P.S. Sorry for discussing unrelated issues in a bug report.
Comment 4 Tiffany Antopolski 2012-03-18 14:21:39 UTC 
Looks like I was wrong ;-)  I have committed your suggested changes:

http://git.gnome.org/browse/evince/commit/?id=a919959861b1a7c373dec2bcf1c7ab662cff91ba