After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672273 - st-texture-cache: Cleanups and deduplication for async URI requests
st-texture-cache: Cleanups and deduplication for async URI requests
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-17 04:06 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-03-18 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-texture-cache: Remove an unused argument from create_default_texture (2.58 KB, patch)
2012-03-17 04:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-texture-cache: Remove unused fields from AsyncTextureLoadData (1.36 KB, patch)
2012-03-17 04:06 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
st-entry: Remove unused set_icon_from_file methods (3.28 KB, patch)
2012-03-17 04:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-texture-cache: Remove now unused methods (5.16 KB, patch)
2012-03-17 04:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-texture-cache: Deduplicate async URI requests (5.47 KB, patch)
2012-03-17 04:06 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-texture-cache: Remove unused fields from AsyncTextureLoadData (2.78 KB, patch)
2012-03-17 04:39 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-03-17 04:06:13 UTC 
See patches. The first for are "unused" cleanups (I seem to be getting
surprisingly good at finding those), and the last one is what I've been
working towards: deduplication for async URI requests.

Going forward on reducing our memory usage, how would people feel about
merging the cairo/cogl surface entries in the keyed cache so we only store
raw texture data and the surfaces are created on the fly?
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-03-17 04:06:15 UTC 
Created attachment 209979 [details] [review]
st-texture-cache: Remove an unused argument from create_default_texture
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-03-17 04:06:18 UTC 
Created attachment 209980 [details] [review]
st-texture-cache: Remove unused fields from AsyncTextureLoadData
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-03-17 04:06:22 UTC 
Created attachment 209981 [details] [review]
st-entry: Remove unused set_icon_from_file methods

This lets us ditch some methods in the texture cache.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-03-17 04:06:24 UTC 
Created attachment 209982 [details] [review]
st-texture-cache: Remove now unused methods

load_uri_sync and load_file_simple are now unused.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-03-17 04:06:27 UTC 
Created attachment 209983 [details] [review]
st-texture-cache: Deduplicate async URI requests

More than one outstanding request to the same URI should now be
deduplicated, and the framework is there if we want to cache async loaded
URIs as well
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-03-17 04:39:23 UTC 
Created attachment 209984 [details] [review]
st-texture-cache: Remove unused fields from AsyncTextureLoadData

Remove the unused "icon" field as well.
Comment 7 drago01 2012-03-17 10:38:28 UTC 
Review of attachment 209979 [details] [review]:

Looks good.
Comment 8 drago01 2012-03-17 10:39:18 UTC 
Review of attachment 209981 [details] [review]:

Looks good.
Comment 9 drago01 2012-03-18 10:35:37 UTC 
Review of attachment 209983 [details] [review]:

Looks good.
Comment 10 drago01 2012-03-18 10:36:28 UTC 
Review of attachment 209982 [details] [review]:

OK.
Comment 11 drago01 2012-03-18 10:38:30 UTC 
Review of attachment 209984 [details] [review]:

OK.
Comment 12 Jasper St. Pierre (not reading bugmail) 2012-03-18 10:43:17 UTC 
Attachment 209979 [details] pushed as 63cf470 - st-texture-cache: Remove an unused argument from create_default_texture
Attachment 209981 [details] pushed as 36d20eb - st-entry: Remove unused set_icon_from_file methods
Attachment 209982 [details] pushed as 0ebddfc - st-texture-cache: Remove now unused methods
Attachment 209983 [details] pushed as 46c0360 - st-texture-cache: Deduplicate async URI requests
Attachment 209984 [details] pushed as db4b266 - st-texture-cache: Remove unused fields from AsyncTextureLoadData