After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672266 - Don't run triggers if not installing
Don't run triggers if not installing
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2012-03-16 22:30 UTC by Giovanni Campagna
Modified: 2012-03-17 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only run triggers if we actually install (1.70 KB, patch)
2012-03-16 22:31 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-03-16 22:30:44 UTC 
Currently jhbuild runs triggers at the end of the build script if not failed, even if installation was skipped. This results in triggers running unnecessarily, which can be annoying if they take long to run.
(In my case, I patched jhbuild locally to run restorecon on the entire prefix for every module, and that can take a while)

Patch follows.
Comment 1 Giovanni Campagna 2012-03-16 22:31:09 UTC 
Created attachment 209966 [details] [review]
Only run triggers if we actually install

If we skip phase install for any reason, for example because the
module is not updated, we don't need to run triggers again.
Comment 2 Colin Walters 2012-03-17 18:29:14 UTC 
Review of attachment 209966 [details] [review]:

This looks OK.
Comment 3 Giovanni Campagna 2012-03-17 19:13:00 UTC 
Attachment 209966 [details] pushed as 64ce297 - Only run triggers if we actually install