After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672087 - Add bw-compatible arguments to Gtk.Adjustment
Add bw-compatible arguments to Gtk.Adjustment
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-14 18:21 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2012-03-16 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add bw-compatible arguments to Gtk.Adjustment (1.36 KB, patch)
2012-03-14 18:21 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2012-03-14 18:21:52 UTC 
The argument used to be called page/step_incr, if they
are found map them to the existing properties for extra
compatibility.
Comment 1 Johan (not receiving bugmail) Dahlin 2012-03-14 18:21:54 UTC 
Created attachment 209768 [details] [review]
Add bw-compatible arguments to Gtk.Adjustment
Comment 2 Paolo Borelli 2012-03-14 22:09:26 UTC 
Review of attachment 209768 [details] [review]:

Looks good to me... I wonder if this level of compat could be a slippery slope, but let's add it, if it grows too much we can revisit the decision
Comment 3 Martin Pitt 2012-03-14 22:11:56 UTC 
FWIW, I'd much rather not have this, and instead add that renaming to pygi-convert.sh. We really should not proliferate such arbitrary renamings and C API breakage in PyGI.
Comment 4 Johan (not receiving bugmail) Dahlin 2012-03-15 13:32:20 UTC 
My usecase prevents me from using pygi-convert.sh, it's only one of the possible migration strategies for PyGTK->PyGI.

I propose that this goes in, since I have code that depends on that and I think it would be useful for others.

After the next release, we'll start moving this and some other PyGTK specific APIs to pygtkcompat.py and leave this as is, would that be okay?
Comment 5 Johan (not receiving bugmail) Dahlin 2012-03-16 19:41:21 UTC 
Attachment 209768 [details] pushed as 680a2e0 - Add bw-compatible arguments to Gtk.Adjustment