After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672050 - Should refresh GoaAccount if EnsureCredential fails
Should refresh GoaAccount if EnsureCredential fails
Status: RESOLVED INVALID
Product: empathy
Classification: Core
Component: Auth client
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-14 13:01 UTC by Xavier Claessens
Modified: 2012-03-15 09:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Xavier Claessens 2012-03-14 13:01:36 UTC 
If GOA's access-token is invalid (expired and cannot be refreshed, or user changed his password, etc) then EnsureCredentials dbus call will fail and AttentionNeeded dbus property is set to TRUE.

In that case, empathy-auth-client should display the web auth page (using webkit) to let user re-enter his credentials, then call EnsureCredentials again to finally get the new access-token. This is done by just calling goa_provider_refresh_account().
Comment 1 Xavier Claessens 2012-03-15 09:24:58 UTC 
Actually I was wrong. I tested by disconnecting my account, remove the facebook app from my fb settings, and they try to reconnect the telepathy account.

I get a notification bubble saying "An online account needs attention" with a button "Open Online Accounts...". Clicking that button does not actually work, but if I open GOA (in g-c-c) manually, it shows a message for my account telling my credentials expired and I have to re-connect, then all is fine.

So this case is actually already covered by GOA itself, even if user experience could be improved a bit.