After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672045 - Add Gtk.Arrow/Gtk.Window constructor override
Add Gtk.Arrow/Gtk.Window constructor override
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-14 12:26 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2012-03-15 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add Gtk.Arrow/Gtk.Window constructor override (1.22 KB, patch)
2012-03-14 12:26 UTC, Johan (not receiving bugmail) Dahlin 		none Details | Review
Add Gtk.Arrow/Gtk.Window constructor override (1.21 KB, patch)
2012-03-14 12:38 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2012-03-14 12:26:05 UTC 
Adds argument that makes them compatible with PyGTK.
Comment 1 Johan (not receiving bugmail) Dahlin 2012-03-14 12:26:08 UTC 
Created attachment 209704 [details] [review]
Add Gtk.Arrow/Gtk.Window constructor override
Comment 2 Martin Pitt 2012-03-14 12:35:23 UTC 
Do the arrow arguments need to be optional for pygtk compat? gtk_arrow_new() requires actual values. The GObject constructor already provides named arguments, so if that's only for providing positional arguments I'd add an assertion that they are not None.
Comment 3 Johan (not receiving bugmail) Dahlin 2012-03-14 12:37:41 UTC 
You're right, I overwsaw that. It's easier to just remove the default values.
Comment 4 Johan (not receiving bugmail) Dahlin 2012-03-14 12:38:37 UTC 
Created attachment 209708 [details] [review]
Add Gtk.Arrow/Gtk.Window constructor override

Adds argument that makes them compatible with PyGTK.
Comment 5 Martin Pitt 2012-03-14 13:26:01 UTC 
Comment on attachment 209708 [details] [review]
Add Gtk.Arrow/Gtk.Window constructor override

Thanks! That looks fine, please commit.
Comment 6 Paolo Borelli 2012-03-14 13:49:32 UTC 
Ideally you'd add testcases to test_overrides.py :)
Comment 7 Martin Pitt 2012-03-15 07:39:47 UTC 
Comment on attachment 209708 [details] [review]
Add Gtk.Arrow/Gtk.Window constructor override

Johan pushed this patch.

However, it broke a test:

======================================================================
FAIL: test_inheritance (test_overrides.TestGtk)
----------------------------------------------------------------------
Traceback (most recent call last):

+ Trace 229881

  • File "/home/martin/upstream/pygobject/tests/test_overrides.py", line 1565 in test_inheritance 
    "%r does not inherit from override %r" % (klass, over,))
AssertionError: <class 'gi.overrides.Gtk.AboutDialog'> does not inherit from override <class 'gi.overrides.Gtk.Window'> 

Johan, can you please fix this? Thanks!
Comment 8 Johan (not receiving bugmail) Dahlin 2012-03-15 18:19:24 UTC 
This regression is fixed in bug 672158