After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672043 - Remove ':' from labels
Remove ':' from labels
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal enhancement
: 3.6
Assigned To: Danielle Madeley
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-14 12:06 UTC by Guillaume Desmottes
Modified: 2012-05-30 02:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Guillaume Desmottes 2012-03-14 12:06:21 UTC 
In http://bugzilla-attachments.gnome.org/attachment.cgi?id=209607 the labels don't contain a trailing ':'. We should remove them in this widget but also in account widgets.

Labels should have a different colour to be distinguished. g-c-c uses:

<style>
   <class name="dim-label"/>
</style>
Comment 2 Guillaume Desmottes 2012-05-23 11:05:02 UTC 
You should use GTK_STYLE_CLASS_DIM_LABEL  (introduced in Gtk+ 3.5.1).

The personnal settings widget is pushed to the right border here:
http://people.collabora.com/~cassidy/accounts.jpg

Advanced settings of XMPP and SIP haven't been updated.

We still have to update the generated widgets and a bunch of other ones.
Comment 3 Danielle Madeley 2012-05-29 07:23:28 UTC 
(In reply to comment #2)
> You should use GTK_STYLE_CLASS_DIM_LABEL  (introduced in Gtk+ 3.5.1).

Fixed.

> The personnal settings widget is pushed to the right border here:
> http://people.collabora.com/~cassidy/accounts.jpg

Fixed.

> Advanced settings of XMPP and SIP haven't been updated.

I decided not to dim the labels because it looks strange on white. Also it looks strange to mix right aligned labels and comboboxes, feel free to overrule me.

> We still have to update the generated widgets and a bunch of other ones.

Done.
Comment 4 Guillaume Desmottes 2012-05-29 10:58:26 UTC 
(In reply to comment #3)
> > Advanced settings of XMPP and SIP haven't been updated.
> 
> I decided not to dim the labels because it looks strange on white. Also it
> looks strange to mix right aligned labels and comboboxes, feel free to overrule
> me.

Let's start like that for now.

Looks good, thanks for your branch.
Comment 5 Danielle Madeley 2012-05-30 02:13:05 UTC 
Merged.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.