After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672038 - Move the fallback define for GL_PACK_INVERT_MESA
Move the fallback define for GL_PACK_INVERT_MESA
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-03-14 11:14 UTC by Allison Karlitskaya (desrt)
Modified: 2012-03-14 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move the fallback define for GL_PACK_INVERT_MESA (1.44 KB, patch)
2012-03-14 11:14 UTC, Allison Karlitskaya (desrt) 		reviewed Details | Review

Description Allison Karlitskaya (desrt) 2012-03-14 11:14:48 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2012-03-14 11:14:49 UTC 
Created attachment 209692 [details] [review]
Move the fallback define for GL_PACK_INVERT_MESA

The if-undefined fallback declaration for GL_PACK_INVERT_MESA was
originally added in cogl.c along with code to use it (as part of commit
6f79eb8a5a530fc2fd0a9aed90da172fbf05f742).  Later on, commit
10a38bb14fac3ba8dc05115feb04bde56dc590e7 moved the code that used it to
cogl-framebuffer.c but didn't move the define along with it.  Do that
now.
Comment 2 Emmanuele Bassi (:ebassi) 2012-03-14 11:43:53 UTC 
Review of attachment 209692 [details] [review]:

seems obviously correct to me
Comment 3 Neil Roberts 2012-03-14 12:17:03 UTC 
Pushed as 6f59993e1b4b925765c9b78853090b7b3bf12635

Thanks!