Bug 672026 - default log output should include pid and/or prgname
default log output should include pid and/or prgname
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-03-13 23:25 UTC by Allison Lortie (desrt) (extended vacation)
Modified: 2012-03-14 00:15 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
glib-init: restore default for G_MESSAGES_PREFIXED (1.74 KB, patch)
2012-03-14 00:15 UTC, Allison Lortie (desrt) (extended vacation) 		committed Details | Diff | Review
g_log: mask log level before checking prefix flags (1.08 KB, patch)
2012-03-14 00:15 UTC, Allison Lortie (desrt) (extended vacation) 		committed Details | Diff | Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Allison Lortie (desrt) (extended vacation) 2012-03-13 23:25:21 UTC 
Guessing what's writing into .xsession-errors isn't a whole lot of fun.
Comment 1 Allison Lortie (desrt) (extended vacation) 2012-03-14 00:15:01 UTC 
Created attachment 209667 [details] [review]
glib-init: restore default for G_MESSAGES_PREFIXED

In the glib-init shuffle this ended up being set to no messages prefixed
by default.  Fix that so that we have prefixes back.
Comment 2 Allison Lortie (desrt) (extended vacation) 2012-03-14 00:15:03 UTC 
Created attachment 209668 [details] [review]
g_log: mask log level before checking prefix flags

We check if the log level is in the "prefixed" list by checking it
against the g_log_msg_prefix bitfield.

Unfortunately we were failing to mask by G_LOG_LEVEL_MASK first, so if
the FATAL bit was set (for example) then it would never match.  This was
the case for g_error().
Comment 3 Allison Lortie (desrt) (extended vacation) 2012-03-14 00:15:34 UTC 
Attachment 209667 [details] pushed as 545736c - glib-init: restore default for G_MESSAGES_PREFIXED
Attachment 209668 [details] pushed as fbbdf98 - g_log: mask log level before checking prefix flags
Note You need to log in before you can comment on or make changes to this bug.