GNOME Bugzilla – Bug 672023
Use $(pkglibdir) instead of $(libdir)/epiphany
Last modified: 2012-07-31 15:37:10 UTC
Created attachment 209658 [details] [review] [PATCH] Use $(pkglibdir) instead of $(libdir)/epiphany We already use pkgdatadir to install the data files. Let's use pkglibdir for the extensions/loaders instead of hard-coding the package name.
Created attachment 209688 [details] [review] [PATCH] Use $(pkglibdir) instead of $(libdir)/epiphany Last patch had a bug. data/epiphany.pc.in is processed by configure, which doesn't know pkglibdir, so we need to use @libdir@/@PACKAGE@ there
Review of attachment 209688 [details] [review]: This seems to be doing two different things with the same goal (to avoid hardcoding the app name). Could you commit them separately?
(In reply to comment #2) > Review of attachment 209688 [details] [review]: > > This seems to be doing two different things with the same goal (to avoid > hardcoding the app name). Could you commit them separately? Do you mean I should commit the changes to .pc.in separate from the changes to lib/Makefile.am and src/Makefile.am? I do think this belongs together, but if you prefer it that way, sure, I can do that.
(In reply to comment #3) > Do you mean I should commit the changes to .pc.in separate from the changes to > lib/Makefile.am and src/Makefile.am? Yes. > > I do think this belongs together, but if you prefer it that way, sure, I can do > that. Well, the changes seem independent one of the other, right? If that's the case they should be in different commits. BTW, please double check that 'make distcheck' still works after this.
Patch status has been "accepted-commit_after_freeze" for more than 3 months now. Which exact freeze does this refer to? Can this get committed, or should the patch status be updated?
I split the patches, distcheck works, and pushed them. Thanks!