After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672023 - Use $(pkglibdir) instead of $(libdir)/epiphany
Use $(pkglibdir) instead of $(libdir)/epiphany
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-13 22:45 UTC by Michael Biebl
Modified: 2012-07-31 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Use $(pkglibdir) instead of $(libdir)/epiphany (2.03 KB, patch)
2012-03-13 22:45 UTC, Michael Biebl 		none Details | Review
[PATCH] Use $(pkglibdir) instead of $(libdir)/epiphany (2.08 KB, patch)
2012-03-14 10:17 UTC, Michael Biebl 		committed Details | Review

Description Michael Biebl 2012-03-13 22:45:33 UTC 
Created attachment 209658 [details] [review]
[PATCH] Use $(pkglibdir) instead of $(libdir)/epiphany

We already use pkgdatadir to install the data files.
Let's use pkglibdir for the extensions/loaders instead of hard-coding the package name.
Comment 1 Michael Biebl 2012-03-14 10:17:58 UTC 
Created attachment 209688 [details] [review]
[PATCH] Use $(pkglibdir) instead of $(libdir)/epiphany

Last patch had a bug. data/epiphany.pc.in is processed by configure, which doesn't know pkglibdir, so we need to use @libdir@/@PACKAGE@ there
Comment 2 Xan Lopez 2012-03-23 14:57:08 UTC 
Review of attachment 209688 [details] [review]:

This seems to be doing two different things with the same goal (to avoid hardcoding the app name). Could you commit them separately?
Comment 3 Michael Biebl 2012-03-23 22:22:22 UTC 
(In reply to comment #2)
> Review of attachment 209688 [details] [review]:
> 
> This seems to be doing two different things with the same goal (to avoid
> hardcoding the app name). Could you commit them separately?

Do you mean I should commit the changes to .pc.in separate from the changes to lib/Makefile.am and src/Makefile.am?

I do think this belongs together, but if you prefer it that way, sure, I can do that.
Comment 4 Xan Lopez 2012-03-27 09:39:30 UTC 
(In reply to comment #3)
> Do you mean I should commit the changes to .pc.in separate from the changes to
> lib/Makefile.am and src/Makefile.am?

Yes.

> 
> I do think this belongs together, but if you prefer it that way, sure, I can do
> that.

Well, the changes seem independent one of the other, right? If that's the case they should be in different commits.

BTW, please double check that 'make distcheck' still works after this.
Comment 5 André Klapper 2012-06-26 12:19:37 UTC 
Patch status has been "accepted-commit_after_freeze" for more than 3 months now.
Which exact freeze does this refer to? Can this get committed, or should the patch status be updated?
Comment 6 Claudio Saavedra 2012-07-31 15:37:07 UTC 
I split the patches, distcheck works, and pushed them. Thanks!