After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671847 - RFC: Don't wait for domain creation event
RFC: Don't wait for domain creation event
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-03-11 21:10 UTC by Zeeshan Ali
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
RFC: Don't wait for domain creation event (3.92 KB, patch)
2012-03-11 21:10 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-03-11 21:10:31 UTC 
libvirt doesn't seem to be very reliable on prolonged sessions so the lesser we depend on it, the better. This patch is mainly a work-around for a very hard to debug/reproduce libvirt issue: It stops sending domain events after libvirtd has been running for a long time (where the definition of 'long time' doesn't seem to be predictable).

OTOH, this patch doesn't do any harm and actually reduces the time it takes before user hitting 'create' button in wizard and new machine appearing in the collection view.
Comment 1 Zeeshan Ali 2012-03-11 21:10:33 UTC 
Created attachment 209448 [details] [review]
RFC: Don't wait for domain creation event

libvirt doesn't seem to be very reliable on prolonged sessions so the
lesser we depend on it, the better. This patch is mainly a work-around
for a very hard to debug/reproduce libvirt issue: It stops sending
domain events after libvirtd has been running for a long time (where the
definition of 'long time' doesn't seem to be predictable).

OTOH, this patch doesn't do any harm and actually reduces the time it
takes before user hitting 'create' button in wizard and new machine
appearing in the collection view.
Comment 2 Marc-Andre Lureau 2012-03-16 15:35:48 UTC 
Review of attachment 209448 [details] [review]:

looks ok (although I hope we could remove it some day, as it shouldn't really be necessary, and may be annoying if libvirt didn't create the VM for some reason...)