After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671799 - Laptop does not suspend on lid close when external display is connected
Laptop does not suspend on lid close when external display is connected
Status: RESOLVED DUPLICATE of bug 657201
Product: gnome-settings-daemon
Classification: Core
Component: power
3.3.x
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-10 21:18 UTC by Roman Mašek
Modified: 2012-03-10 23:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch: suspend on close lid even when external display is connected (747 bytes, application/octet-stream)
2012-03-10 21:18 UTC, Roman Mašek
  Details
patch v2: suspend on close lid even when external display is connected (1.91 KB, patch)
2012-03-10 23:08 UTC, Roman Mašek
rejected Details | Review

Description Roman Mašek 2012-03-10 21:18:54 UTC
Created attachment 209413 [details]
patch: suspend on close lid even when external display is connected

I've configured my laptop to suspend when the lid is closed (in gnome-control-center's Power panel). It works ok as long as there is no external display connected. However when I connect my external LCD, laptop IS NOT suspended (external display is turned off though).

I'm experiencing this in Unity on Ubuntu 12.04 (see related bug report there [1]). However from code it seems that this issue affects Gnome too.

I've done some research and found out that problem is in gnome-settings-daemon package: There is code in gsd-power-manager.c in do_lid_closed_action function which checks whether there are any active external outputs and if it finds any, it prevents suspending. I believe that in this case we should honor what's set in gnome-control-center and suspend. Patch which removes this logic is attached.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: gnome-settings-daemon 3.3.91-0ubuntu2 [modified: usr/lib/gnome-settings-daemon-3.0/libpower.so]
ProcVersionSignature: Ubuntu 3.2.0-18.28-generic 3.2.9
Uname: Linux 3.2.0-18-generic x86_64
ApportVersion: 1.94.1-0ubuntu1
Architecture: amd64
Date: Sat Mar 10 21:21:00 2012
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha amd64 (20120309)
ProcEnviron:
 TERM=xterm
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-settings-daemon
UpgradeStatus: No upgrade log present (probably fresh install)

[1] https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/951790
Comment 1 Roman Mašek 2012-03-10 23:08:47 UTC
Created attachment 209415 [details] [review]
patch v2: suspend on close lid even when external display is connected

I've attached revised version of the patch. It removes logic which tries to decide whether output is external or not and whether it should suspend then.
Comment 2 Bastien Nocera 2012-03-10 23:33:14 UTC
Goes against the design, which is that the laptop should *not* suspend when an external display is used.

Removing code that was recently added to follow designs isn't an option.

*** This bug has been marked as a duplicate of bug 657201 ***