After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671792 - Should append file:// to existing absolute paths
Should append file:// to existing absolute paths
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] URL bar
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-10 19:57 UTC by Gustavo Noronha (kov)
Modified: 2012-03-14 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Automatically prefix existing absolute paths with file:// (4.80 KB, patch)
2012-03-10 20:05 UTC, Gustavo Noronha (kov) 		reviewed Details | Review
Automatically prefix existing absolute paths with file:// (4.36 KB, patch)
2012-03-13 23:12 UTC, Gustavo Noronha (kov) 		committed Details | Review

Description Gustavo Noronha (kov) 2012-03-10 19:57:23 UTC 
So we can just type /home/kov, for instance, instead of file:///home/kov.
Comment 1 Gustavo Noronha (kov) 2012-03-10 20:05:30 UTC 
Created attachment 209410 [details] [review]
Automatically prefix existing absolute paths with file://
Comment 2 Xan Lopez 2012-03-13 10:38:21 UTC 
Review of attachment 209410 [details] [review]:

::: embed/ephy-web-view.c
@@ +2467,3 @@
+      temp_url = g_strconcat ("file://", effective_url, NULL);
+    else
+      temp_url = g_strconcat ("http://", effective_url, NULL);

This happens after the URI has been normalized, so anything starting with '/' that is a valid path should already have file:// before it, right? Why is it needed?
Comment 3 Gustavo Noronha (kov) 2012-03-13 23:05:41 UTC 
Review of attachment 209410 [details] [review]:

::: embed/ephy-web-view.c
@@ +2467,3 @@
+      temp_url = g_strconcat ("file://", effective_url, NULL);
+    else
+      temp_url = g_strconcat ("http://", effective_url, NULL);

Oops. That's how I started the patch, probably just forgot to remove it, it is indeed not needed!
Comment 4 Gustavo Noronha (kov) 2012-03-13 23:12:18 UTC 
Created attachment 209665 [details] [review]
Automatically prefix existing absolute paths with file://
Comment 5 Xan Lopez 2012-03-14 08:45:12 UTC 
Review of attachment 209665 [details] [review]:

Thank you, looks good now.
Comment 6 Gustavo Noronha (kov) 2012-03-14 15:34:14 UTC 
Comment on attachment 209665 [details] [review]
Automatically prefix existing absolute paths with file://

398e670b1dd80cd0427a1db8a21dfc892bbe5eaf

Thanks =)