After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671789 - fix eog dependencies and suggests
fix eog dependencies and suggests
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
3.4.x
Other Linux
: Normal trivial
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2012-03-10 18:58 UTC by Felix Riemann
Modified: 2012-03-11 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
3.4: Fix eog dependencies and suggests (1.65 KB, patch)
2012-03-10 18:58 UTC, Felix Riemann 		accepted-commit_now Details | Review

Description Felix Riemann 2012-03-10 18:58:11 UTC 
Created attachment 209406 [details] [review]
3.4: Fix eog dependencies and suggests

Posting this change here for a review by a jhbuild expert as I'm not quite used to jhbuild's dependency model.

The story behind this is, that I noticed that eog wasn't listed with all its required and optional dependencies. To change that I added all required dependencies to the "<dependencies>" tag and all optional deps to the "<suggests>" tag and did the same for eog-plugins.

Was this the correct way to do fix it?
Comment 1 Frederic Peters 2012-03-11 10:33:50 UTC 
Comment on attachment 209406 [details] [review]
3.4: Fix eog dependencies and suggests

Yeah, it's fine, thanks for the patch.
Comment 2 Felix Riemann 2012-03-11 15:46:45 UTC 
Thanks for confirming. :)

commit dd51577ddcf0d876f58159f365a0c5223a7052e9
Author: Felix Riemann <>
Date:   Sat Mar 10 19:53:23 2012 +0100

    3.4: Fix eog dependencies and suggests
    
    Also for eog-plugins.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=671789