After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671772 - Add deprecation attributes to deprecated functions
Add deprecation attributes to deprecated functions
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
3.4.x
Other All
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-10 12:48 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-08-27 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add deprecation attributes to deprecated functions (2.47 KB, patch)
2012-03-10 12:49 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-03-10 12:48:53 UTC 
This is using the newly introduce G_DEPRECATED macros
from GLib. Traditional deprecation guards are still in
place.
Comment 1 Javier Jardón (IRC: jjardon) 2012-03-10 12:49:38 UTC 
Created attachment 209387 [details] [review]
Add deprecation attributes to deprecated functions
Comment 2 Javier Jardón (IRC: jjardon) 2012-06-30 11:01:09 UTC 
ping
Comment 3 Matthias Clasen 2012-08-18 21:16:47 UTC 
Review of attachment 209387 [details] [review]:

Looks fine to me
Comment 4 Vincent Untz 2012-08-27 08:45:28 UTC 
Review of attachment 209387 [details] [review]:

Please commit after doing the small change suggested below.

::: configure.ac
@@ +137,3 @@
 AC_SUBST(XLIB_LIBS)
 
+GLIB_REQUIRED_VERSION=2.31

Either move all versions to such variable (gtk+-3.0 and gthread-2.0), or do not create a GLIB_REQUIRED_VERSION variable.
Comment 5 Javier Jardón (IRC: jjardon) 2012-08-27 15:59:08 UTC 
Comment on attachment 209387 [details] [review]
Add deprecation attributes to deprecated functions

commited with your comments, thanks for the review
commit cbc1c00f27777400e80582c1264e3061786e6845