After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671770 - Add deprecation attributes to deprecated functions
Add deprecation attributes to deprecated functions
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: API
2.37.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2012-03-10 12:38 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-07-07 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add deprecation attributes to deprecated functions (1.73 KB, patch)
2012-03-10 12:39 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Replace deprecated symbols (4.26 KB, patch)
2012-07-05 14:54 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2012-03-10 12:38:32 UTC 
This is using the newly introduce G_DEPRECATED macros
from GLib. Traditional deprecation guards are still in
place.
Comment 1 Javier Jardón (IRC: jjardon) 2012-03-10 12:39:41 UTC 
Created attachment 209382 [details] [review]
Add deprecation attributes to deprecated functions
Comment 2 Javier Jardón (IRC: jjardon) 2012-06-30 11:01:17 UTC 
ping
Comment 3 Dan Winship 2012-07-04 15:17:00 UTC 
Comment on attachment 209382 [details] [review]
Add deprecation attributes to deprecated functions

Sorry... this fell off my radar

>+G_DEPRECATED
> const char         *soup_message_headers_get      (SoupMessageHeaders *hdrs,

should be G_DEPRECATED_FOR(soup_message_headers_get_one or soup_message_headers_get_list)
(pretty sure the macro lets you do that...)

OK to commit assuming that does work.

(Though bonus points if you also write a patch to fix the soup-cache.c warnings this will cause...)
Comment 4 Javier Jardón (IRC: jjardon) 2012-07-05 14:53:04 UTC 
Hey Dan,

Ive committed the patch with your comments

commit 804281853d8a683bfdb61310827c16101fe8414b
Comment 5 Javier Jardón (IRC: jjardon) 2012-07-05 14:54:48 UTC 
Created attachment 218099 [details] [review]
Replace deprecated symbols

 ... But I want the extra points so here the patch to replace the deprecation warnings ;)
Comment 6 Javier Jardón (IRC: jjardon) 2012-07-05 14:55:31 UTC 
Used this: http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
Comment 7 Dan Winship 2012-07-05 21:43:35 UTC 
Comment on attachment 218099 [details] [review]
Replace deprecated symbols

great. thanks!
Comment 8 Javier Jardón (IRC: jjardon) 2012-07-07 15:58:58 UTC 
Comment on attachment 218099 [details] [review]
Replace deprecated symbols

40632ba129a178ddb4fe6ffb5164c9a1071cb323