GNOME Bugzilla – Bug 671720
The video preview is not rounded the same way as its highlight rectangle
Last modified: 2012-03-12 12:02:49 UTC
In the clutter call window the highlight rectangle has a different roundedness size than the video preview, as one is specified in absolute pixels while the other as a ratio based on the height of the actor.
Created attachment 209325 [details] [review] Match the preview highlight roundedness with the video Add empathy_rounded_rectangle_set_round_factor() to have the same roundedness on the preview video and related highlight/placeholders.
Created attachment 209462 [details] [review] Rebased on top of the clutter-api branch Re-spin, this time basing the patch on the following branch: http://cgit.collabora.com/git/user/cassidy/empathy/log/?h=clutter-api (well, actually a fast-forwarded version of it on top of master)
Whole branch available at http://cgit.collabora.com/git/user/em/empathy.git/log/?h=fix-highlight-roundedness-671720
Review of attachment 209462 [details] [review]: ::: src/empathy-call-window.c @@ +649,3 @@ + SELF_VIDEO_SECTION_HEIGHT + 2 * SELF_VIDEO_SECTION_MARGIN); + + empathy_rounded_rectangle_set_round_factor (rectangle, PREVIEW_ROUND_FACTOR); As we never change it afterward (which makes sense), wouldn't be best to pass the round-factor to _new() directly? @@ +670,2 @@ clutter_container_add_actor (CLUTTER_CONTAINER (box1), box2); + clutter_container_add_actor (CLUTTER_CONTAINER (box2), CLUTTER_ACTOR(rectangle)); Should be 'CLUTTER_ACTOR (rectangle)'. @@ +674,3 @@ box1, x, y); + clutter_actor_hide (CLUTTER_ACTOR(rectangle)); same here. @@ +678,1 @@ + return CLUTTER_ACTOR(rectangle); ditto
Created attachment 209470 [details] [review] Pass the roundedness factor to empathy_[actor|rectangle]_new() Drop the empathy_[actor|rectangle]_set_round_factor() functions and pass the roundedness factor to the contructor as it cannot be changed. Also fixed some coding style issues.