After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671706 - build: Remove use of -Werror
build: Remove use of -Werror
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-09 10:28 UTC by Bastien Nocera
Modified: 2012-03-11 12:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Remove use of -Werror (1.62 KB, patch)
2012-03-09 10:28 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2012-03-09 10:28:06 UTC
See patch for reasoning
Comment 1 Bastien Nocera 2012-03-09 10:28:08 UTC
Created attachment 209307 [details] [review]
build: Remove use of -Werror

This regularly breaks with deprecation, and I don't think
that a build breaking every development cycle is anything interesting
to developers interested in casual bug fixing and development.
Comment 2 Jonathan Matthew 2012-03-11 12:38:20 UTC
I want to keep -Werror, and it has value for casual bug fixers too.  -Wno-deprecated-declarations is what we want here.  I've added that in commit 362b701.