GNOME Bugzilla – Bug 671601
Access on unreffed pointer
Last modified: 2012-03-19 17:03:28 UTC
Created attachment 209218 [details] [review]
In meta_screen_remove_workspace function, after having called meta_workspace_remove which unref the workspace pointer, we still use workspace->screen.
Turned out to segfault on a setups.
Attached is a patch to remove this unreffed pointer access.
Review of attachment 209218 [details] [review]:
Florian, should we get this in for 3.4 ?
(In reply to comment #3)
> Florian, should we get this in for 3.4 ?
As Owen says, it doesn't matter for GNOME Shell 3.4 -- JS will always have a reference to the object. It's still a bug, but it shouldn't matter if it slips through the cracks.
but there's no need for it to slip through, right ? we have a patch, it is marked a-c-n, all we need is somebody to commit it...
I happen to have the right to commit (if nobody is willing to do it). :)
"accepted-commit_now" means "please use your commit rights"
Go ahead then :)
Comment on attachment 209218 [details] [review]
[Updating patch status]